You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/20 22:50:05 UTC
[GitHub] [airflow] potiuk opened a new pull request #21000: Update md5 information about image after waiting
potiuk opened a new pull request #21000:
URL: https://github.com/apache/airflow/pull/21000
When "wait_for_image" was called, the information that the image
was built (including the information about md5 hashes of important
files) had not been stored locally. It was only stored when
image was pulled by "prepare_image". Constraints job uses
wait for image, because it runs in parallel for all python versions.
With recent changes, the flag that image had never been built,
automatically generates image build - unnecessarily, because the
image is already pulled by "wait_for_image".
It made almost no difference for "regular builds" because the image
is rebuilt from cache (which is now very quick) but in case of
PRs that change setup.py it caused image rebuild. Additionally if
this iamge has conflicting requirement, it would cause build failure.
The change simply registers the fact that image is "ok" so that
no attempt to rebuild image happens when constraints are generated.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21000: Update md5 information about image after waiting
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21000:
URL: https://github.com/apache/airflow/pull/21000#issuecomment-1018326275
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21000: Update md5 information about image after waiting
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21000:
URL: https://github.com/apache/airflow/pull/21000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21000: Update md5 information about image after waiting
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21000:
URL: https://github.com/apache/airflow/pull/21000#issuecomment-1017996065
Hey @ashb - this one line missing in recent "buildx" caused the constraint failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org