You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by mi...@apache.org on 2016/03/26 11:24:32 UTC

lucene-solr:master: the scratch BytesRef must be private to each offline reader

Repository: lucene-solr
Updated Branches:
  refs/heads/master 78d5cfefe -> 6d288704c


the scratch BytesRef must be private to each offline reader


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/6d288704
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/6d288704
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/6d288704

Branch: refs/heads/master
Commit: 6d288704c447a129fc73bdc03d36fe0b6cc6fe4b
Parents: 78d5cfe
Author: Mike McCandless <mi...@apache.org>
Authored: Sat Mar 26 06:25:53 2016 -0400
Committer: Mike McCandless <mi...@apache.org>
Committed: Sat Mar 26 06:25:53 2016 -0400

----------------------------------------------------------------------
 lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6d288704/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java b/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
index e075ced..33f72e4 100644
--- a/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
+++ b/lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java
@@ -735,8 +735,6 @@ public class BKDWriter implements Closeable {
       // TODO: this is sort of sneaky way to get the final OfflinePointWriter from OfflineSorter:
       IndexOutput[] lastWriter = new IndexOutput[1];
 
-      final BytesRef scratch = new BytesRef(new byte[bytesPerDoc]);
-
       OfflineSorter sorter = new OfflineSorter(tempDir, tempFileNamePrefix + "_bkd" + dim, cmp, OfflineSorter.BufferSize.megabytes(Math.max(1, (long) maxMBSortInHeap)), OfflineSorter.MAX_TEMPFILES) {
 
           /** We write/read fixed-byte-width file that {@link OfflinePointReader} can read. */
@@ -756,6 +754,7 @@ public class BKDWriter implements Closeable {
           @Override
           protected ByteSequencesReader getReader(ChecksumIndexInput in, String name) throws IOException {
             return new ByteSequencesReader(in, name) {
+              final BytesRef scratch = new BytesRef(new byte[bytesPerDoc]);
               @Override
               public BytesRef next() throws IOException {
                 if (in.getFilePointer() >= end) {