You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2013/03/15 13:01:36 UTC

[Apache Bloodhound] #466: Add a dismiss button to widget_alert

#466: Add a dismiss button to widget_alert
------------------------------+-----------------------
 Reporter:  rjollos           |      Owner:  rjollos
     Type:  enhancement       |     Status:  new
 Priority:  minor             |  Milestone:  Release 6
Component:  ui design         |    Version:
 Keywords:  widget bootstrap  |
------------------------------+-----------------------
 Add a [http://twitter.github.com/bootstrap/components.html#alerts dismiss
 button] to `widget_alert.html`.

 This is a simple one-line addition:
 {{{
 #!python
 <button type="button" class="close" data-dismiss="alert">&times;</button>
 }}}

 Which results in:

 [[Image(DismissAlert.png)]]

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/466>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #466: Add a dismiss button to widget_alert

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#466: Add a dismiss button to widget_alert
--------------------------+------------------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  new
  Priority:  minor        |  Milestone:  Release 6
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  widget bootstrap
--------------------------+------------------------------

Comment (by jdreimann):

 I've got no issues with this.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/466#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #466: Add a dismiss button to widget_alert

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#466: Add a dismiss button to widget_alert
--------------------------+------------------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  new
  Priority:  minor        |  Milestone:  Release 6
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  widget bootstrap
--------------------------+------------------------------

Comment (by olemis):

 Replying to [comment:1 rjollos]:
 > @Olemis: I wanted to check with you before making this change, since the
 widgets are your creation. I also wasn't sure whether the change would be
 appropriate for any of the other widgets in addition to
 `widget_alert.html`.

 I see no major trouble with doing so . We might want to add another
 template parameter to show / hide close button ... but it's low priority .

 IMO @jdreimann has the final word when it comes to GUI and UX .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/466#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #466: Add a dismiss button to widget_alert

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#466: Add a dismiss button to widget_alert
--------------------------+------------------------------
  Reporter:  rjollos      |      Owner:  rjollos
      Type:  enhancement  |     Status:  new
  Priority:  minor        |  Milestone:  Release 6
 Component:  ui design    |    Version:
Resolution:               |   Keywords:  widget bootstrap
--------------------------+------------------------------

Comment (by rjollos):

 @Olemis: I wanted to check with you before making this change, since the
 widgets are your creation. I also wasn't sure whether the change would be
 appropriate for any of the other widgets in addition to
 `widget_alert.html`.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/466#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker