[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2006: Add Decimal256Builder and Decimal256Array (generic approach)

[GitBox <gi...@apache.org>]

HaoYang670 commented on code in PR #2006:
URL: https://github.com/apache/arrow-rs/pull/2006#discussion_r914246297


##########
arrow/src/array/array_decimal.rs:
##########
@@ -32,7 +32,16 @@ use crate::datatypes::{
     DECIMAL_MAX_SCALE,
 };
 use crate::error::{ArrowError, Result};
-use crate::util::decimal::{BasicDecimal, Decimal128};
+use crate::util::decimal::{BasicDecimal, Decimal128, Decimal256};
+use std::marker::PhantomData;
+
+pub struct GenericDecimalArray<T: BasicDecimal, const VALUE_LENGTH: i32> {

Review Comment:
   One little concern is that we could remove `T: BasicDecimal` if we also do const generic on `Decimal128` and `Decimal256`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org