You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/01 06:37:51 UTC
[GitHub] [geode] gesterzhou opened a new pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue
gesterzhou opened a new pull request #5492:
URL: https://github.com/apache/geode/pull/5492
Co-authored-by: Darrel Schneider <da...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] agingade commented on a change in pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue
Posted by GitBox <gi...@apache.org>.
agingade commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481287853
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -755,12 +755,16 @@ public boolean put(Object object) throws InterruptedException, CacheException {
bucketFullPath, brq);
}
if (brq != null) {
+ boolean intializingLocked = brq.lockWhenRegionIsInitializing();
Review comment:
Can we add unit tests to make sure failed Initialization lock is held during put.
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -755,12 +755,16 @@ public boolean put(Object object) throws InterruptedException, CacheException {
bucketFullPath, brq);
}
if (brq != null) {
+ boolean intializingLocked = brq.lockWhenRegionIsInitializing();
brq.getInitializationLock().readLock().lock();
try {
putIntoBucketRegionQueue(brq, key, value);
putDone = true;
} finally {
brq.getInitializationLock().readLock().unlock();
+ if (intializingLocked) {
Review comment:
I assume we don't have to worry about the above unlock code throwing any exception...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481718727
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -755,12 +755,16 @@ public boolean put(Object object) throws InterruptedException, CacheException {
bucketFullPath, brq);
}
if (brq != null) {
+ boolean intializingLocked = brq.lockWhenRegionIsInitializing();
brq.getInitializationLock().readLock().lock();
try {
putIntoBucketRegionQueue(brq, key, value);
putDone = true;
} finally {
brq.getInitializationLock().readLock().unlock();
+ if (intializingLocked) {
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou merged pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue
Posted by GitBox <gi...@apache.org>.
gesterzhou merged pull request #5492:
URL: https://github.com/apache/geode/pull/5492
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #5492:
URL: https://github.com/apache/geode/pull/5492#discussion_r481718201
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -755,12 +755,16 @@ public boolean put(Object object) throws InterruptedException, CacheException {
bucketFullPath, brq);
}
if (brq != null) {
+ boolean intializingLocked = brq.lockWhenRegionIsInitializing();
Review comment:
added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org