You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/11/08 00:42:02 UTC
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/142
Clicking on Copy in API Url style fix
Closes COUCHDB-2441
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/benkeen/couchdb-fauxton 2441-copy-action-style-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 4ee208efa51728988ae7fc44934e82d912977941
Author: Benjamin Keen <be...@gmail.com>
Date: 2014-11-07T23:40:28Z
Clicking on Copy in API Url style fix
Closes COUCHDB-2441
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62238346
Took a quick look. I saw the color change. To be honest, the transition was so quick that you have to know it's there to notice it. So, I might agree with you on not being convinced. Is the concern that we're not notifying the user that they copied the URL to the clipboard because the transition is too quick?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62934680
Thanks @robertkowalski. Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62454415
Hey @seanbarclay, updated. Mind taking a glance?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62609171
LGTM- thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-63040073
please change the commit message (it describes another issue where we landed the fix this week)
after squashing I am +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62232061
Hi @seanbarclay, mind reviewing this when you get a moment? When clicking on the Copy button in the API Url tray, the input field would go white. I added a sort of fade in effect where it briefly goes red then fades out... it looks okay I think, but I'm not convince about the colour.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62619243
Thanks, @seanbarclay! There's not much to review, but I'll wait for a code +1 before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by seanbarclay <gi...@git.apache.org>.
Github user seanbarclay commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62406563
Here's what i would suggest- show an alert that you successfully copied the URL. You can either use the global page one, or you can have it appear on top of the API URL pop-over after you've clicked the copy URL button. Additionally, I wouldn't suggest automatically closing the pop-over on click of the copy button. Let's notify the user that the URL has been copied first, then they they can click off and close the pop-over. Savvy that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62245941
Hmm now you say that, yeah I guess it is a pretty fast... let me slow it down a bit. And any preferences on the colour?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-63105272
Merged as 6d93fe4
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#discussion_r20283476
--- Diff: app/addons/fauxton/components.js ---
@@ -183,14 +183,12 @@ function(app, FauxtonAPI, ace, spin, ZeroClipboard) {
});
client.on("load", function(e){
- var $apiInput = $('#api-navbar input');
- var copyURLTimer;
- client.on("mouseup", function(e){
- $apiInput.css("background-color","#aaa");
- window.clearTimeout(copyURLTimer);
- copyURLTimer = setInterval(function () {
- $apiInput.css("background-color","#fff");
- }, 200);
+ client.on("mouseup", function() {
+ FauxtonAPI.addNotification({
+ msg: "The API URL has been copied to the clipboard.",
+ type: "success",
+ clear: true
+ });
--- End diff --
would just change it according to the styleguide
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-63092841
Oh weird! Thanks @robertkowalski.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: Clicking on Copy in API Url style fi...
Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/142#issuecomment-62408095
Mos def! Yeah, I like that. I think I'd favour the global one for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---