You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/05/12 02:56:46 UTC
Review Request 34068: The test case of extend hashmap to support
custom equality and hash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84668
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment136019>
yes, let me update
- haosdent huang
On May 20, 2015, 7:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 7:10 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84667
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment136018>
how about `foreach (const char c, key)`
- Alexander Rojas
On May 20, 2015, 9:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 9:10 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84953
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33792, 34068]
All tests passed.
- Mesos ReviewBot
On May 22, 2015, 5:49 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 22, 2015, 5:49 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review87743
-----------------------------------------------------------
Ship it!
Minor style issue, I'll clean it up for you and get this committed.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment140153>
Whitespace here to match our other code:
```
$ grep -R "operator ()" src
src/master/allocator/sorter/drf/sorter.cpp:bool DRFComparator::operator () (const Client& client1, const Client& client2)
src/master/allocator/sorter/drf/sorter.hpp: virtual bool operator () (const Client& client1, const Client& client2);
src/master/registrar.hpp: Try<bool> operator () (
```
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment140154>
Ditto here.
- Ben Mahler
On June 1, 2015, 6:55 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:55 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review85960
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33792, 34068]
All tests passed.
- Mesos ReviewBot
On June 1, 2015, 6:55 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:55 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 6:55 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 6:08 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated June 1, 2015, 4:18 a.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Changes
-------
Rebase from current master
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 22, 2015, 5:49 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84603
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33792, 34068]
All tests passed.
- Mesos ReviewBot
On May 20, 2015, 7:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 7:10 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 7:10 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 7:08 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 7:04 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp bba62b393dc863e724cb602b1504eb6517ae9730
3rdparty/libprocess/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 6:51 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp bba62b393dc863e724cb602b1504eb6517ae9730
3rdparty/libprocess/src/encoder.hpp f1b91cf4fc215b6cc8f73285408384269a9bb894
3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 6:40 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/
-----------------------------------------------------------
(Updated May 20, 2015, 6:22 p.m.)
Review request for mesos, Alexander Rojas and Ben Mahler.
Repository: mesos
Description
-------
The test case of extend hashmap to support custom equality and hash
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
Diff: https://reviews.apache.org/r/34068/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84464
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135756>
+1
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135757>
+1
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135759>
I'm not sure what the use case for the case insensitive hash is, but the algorithm you use here only works with alpha numeric strings in the ascii ream. But what happens with "É" and "é" (ASCII 131 and 142).
BenM approach looks much safer.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135760>
+1 In general avoid printing anything to the console. Nobody actually looks at it unless the test fails and in that case we go to the code.
- Alexander Rojas
On May 12, 2015, 2:56 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 2:56 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by haosdent huang <ha...@gmail.com>.
> On May 19, 2015, 8:05 p.m., Ben Mahler wrote:
> > Thanks for the test! I left some comments that are relevant to https://reviews.apache.org/r/33793/ as well, so be sure to update that review too.
@arojas @bmahler Thank you very much for your reviews. I update the patch, could you help me check it again? Thank you.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84370
-----------------------------------------------------------
On May 20, 2015, 7:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 20, 2015, 7:10 p.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review84370
-----------------------------------------------------------
Thanks for the test! I left some comments that are relevant to https://reviews.apache.org/r/33793/ as well, so be sure to update that review too.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135585>
Let's call this something that tells us what it does, how about: 'CaseInsensitiveHash'?
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135582>
Style guide for this is:
```
size_t operator () (...) const
{
}
```
Note the whitespace and that braces should be on the next line for functions.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135586>
Don't think we've been using std::size_t instead of just size_t in the rest of the code.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135589>
You need <ctype.h> for tolower. Also, we haven't been using the C++ include version <cctype> with the std:: prefix. So you can remove the std:: qualifier here.
Also, do you need an include for hash_combine?
```
#include <boost/functional/hash.hpp>
```
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135581>
Let's call this 'CaseInsensitiveEqual' to make it easier for someone to understand when they're reading this code :)
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135583>
Ditto here for whitespace and brace on the next line.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135588>
This looks pretty tricky to understand, also note that you're looping the shorter of the two strings even if they are not the same length.
How about the following?
```
{
if (left.size() != right.size()) {
return false;
}
for (size_t i = 0; i < left.size(); ++i) {
if (std::tolower(c
}
return true;
}
```
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135591>
Please avoid printing unnecessary output in the test :)
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135592>
Ditto here.
3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
<https://reviews.apache.org/r/34068/#comment135594>
Most of these look like they can be EXPECTs instead of ASSERTs, the latter you want only when the test cannot proceed if the assertion fails. But in most of the cases you here, it's ok to continue checking things.
Can you re-organize this a bit, it's hard to follow that you're testing the things we care about. Also, how about just sticking with 'put' and 'get', rather than also using '[]' and 'contains' here?
- Ben Mahler
On May 12, 2015, 12:56 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 12:56 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 34068: The test case of extend hashmap to support
custom equality and hash
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34068/#review83339
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33792, 34068]
All tests passed.
- Mesos ReviewBot
On May 12, 2015, 12:56 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34068/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 12:56 a.m.)
>
>
> Review request for mesos, Alexander Rojas and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The test case of extend hashmap to support custom equality and hash
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp e8a932e5474bf2ba1a93a945ff9bc61fb5146c02
>
> Diff: https://reviews.apache.org/r/34068/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>