You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/31 03:37:06 UTC

[GitHub] zhongjiajie commented on a change in pull request #4583: [AIRFLOW-3746] Fix to prevent missing container exit

zhongjiajie commented on a change in pull request #4583: [AIRFLOW-3746] Fix to prevent missing container exit
URL: https://github.com/apache/airflow/pull/4583#discussion_r252525314
 
 

 ##########
 File path: airflow/operators/docker_operator.py
 ##########
 @@ -228,7 +228,10 @@ def execute(self, context):
             self.cli.start(self.container['Id'])
 
             line = ''
-            for line in self.cli.logs(container=self.container['Id'], stream=True):
+            for line in self.cli.attach(container=self.container['Id'],
+                                        stdout=True,
+                                        stderr=True,
+                                        stream=True):
 
 Review comment:
   You have to create JIRA ticket,because you change code

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services