You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/12/26 06:10:16 UTC

[GitHub] [apisix] spacewander commented on a diff in pull request #8567: feat: consumer-restriction plugin support consumer_group_id type

spacewander commented on code in PR #8567:
URL: https://github.com/apache/apisix/pull/8567#discussion_r1057084335


##########
t/plugin/consumer-restriction.t:
##########
@@ -1436,3 +1436,254 @@ passed
 GET /t
 --- response_body
 passed
+
+
+
+=== TEST 54: create consumer group(group1)

Review Comment:
   Could you move the new tests to a new file?
   
   > When the test file is too large, for example > 800 lines, you should split it to a new file. Please take a look at t/plugin/limit-conn.t and t/plugin/limit-conn2.t.
   
   https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#check-code-style-and-test-case-style
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org