You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Steve Loughran (Commented) (JIRA)" <ji...@apache.org> on 2012/03/15 22:16:38 UTC

[jira] [Commented] (MAPREDUCE-4014) Make yarn-common services robust

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230558#comment-13230558 ] 

Steve Loughran commented on MAPREDUCE-4014:
-------------------------------------------

I'm going to submit an initial patch soon, but want to flag up something first. Should CompositeService attempt to {{stop()}} all its child services when told to {{stop()}} itself - regardless of what state the it is in? This would be consistent with a philosophy of "support the stop operation regardless of your state".

Without that you can't reliably clean up during failed start operations -which the CompositeService itself tries to do by stopping all child services if any one of them fails to start - including the service that failed.
                
> Make yarn-common services robust
> --------------------------------
>
>                 Key: MAPREDUCE-4014
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4014
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.1, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>              Labels: yarn
>
> Review the yarn common services ({{CompositeService}}, {{AbstractLivelinessMonitor}} and make their service startup _and especially shutdown_ more robust against out-of-lifecycle invocation and partially complete initialization.
> Write tests for these where possible. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira