You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/20 19:38:58 UTC
[GitHub] [superset] ad-m opened a new pull request #18120: refactor: migrate SliderControl to TypeScript & added story
ad-m opened a new pull request #18120:
URL: https://github.com/apache/superset/pull/18120
### SUMMARY
Migrated SliderControl to TypeScript to apply direction outlined in #18100 .
In addition, added a new story to visualize that component.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Storybook can be used to verify that changes.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: see #18100
- [x] Required feature flags: no
- [x] Changes UI: no
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)): no
- [x] Migration is atomic, supports rollback & is backwards-compatible: N/A
- [x] Confirm DB migration upgrade and downgrade tested: N/A
- [x] Runtime estimates and downtime expectations provided: N/A
- [x] Introduces new feature or API: no
- [x] Removes existing feature or API: no
@kgabryje , @asadUllah58 You might be interested in this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #18120:
URL: https://github.com/apache/superset/pull/18120#issuecomment-1017888864
# [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18120](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7caa743) into [master](https://codecov.io/gh/apache/superset/commit/1f8129241ba197a25795f1a9459996df9b696a4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f81292) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18120 +/- ##
==========================================
- Coverage 65.74% 65.74% -0.01%
==========================================
Files 1577 1577
Lines 61807 61804 -3
Branches 6243 6243
==========================================
- Hits 40637 40633 -4
- Misses 19569 19570 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/controls/SliderControl.tsx](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLnRzeA==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f81292...7caa743](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #18120:
URL: https://github.com/apache/superset/pull/18120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789156508
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
Review comment:
It might break users of that component, because we had previously `props.default`, so I need to keep `default`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
ad-m commented on pull request #18120:
URL: https://github.com/apache/superset/pull/18120#issuecomment-1034349607
@kgabryje is there anything missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18120:
URL: https://github.com/apache/superset/pull/18120#issuecomment-1017888864
# [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18120](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7caa743) into [master](https://codecov.io/gh/apache/superset/commit/1f8129241ba197a25795f1a9459996df9b696a4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f81292) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 7caa743 differs from pull request most recent head 45947bc. Consider uploading reports for the commit 45947bc to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18120 +/- ##
==========================================
- Coverage 65.74% 65.74% -0.01%
==========================================
Files 1577 1577
Lines 61807 61804 -3
Branches 6243 6243
==========================================
- Hits 40637 40633 -4
- Misses 19569 19570 +1
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/controls/SliderControl.tsx](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLnRzeA==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f81292...45947bc](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789613146
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
};
-const defaultProps = {
- onChange: () => {},
-};
-
-export default function SliderControl(props) {
+export default function SliderControl(props: SliderControlProps) {
+ const { default: defaultValue, ...rest } = props;
Review comment:
Can you add the default value for `onChange` please? I'm not sure if it's actually needed, but it won't hurt to keep it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789637762
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
};
-const defaultProps = {
- onChange: () => {},
-};
-
-export default function SliderControl(props) {
+export default function SliderControl(props: SliderControlProps) {
+ const { default: defaultValue, ...rest } = props;
Review comment:
I think this is not required, but sure I can added it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ad-m commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
ad-m commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789156508
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
Review comment:
It might break users of that components, because we had previously `props.default`, so I need to keep `default`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789612516
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
Review comment:
Agreed, `defaultValue` is a better name than `default`, but changing that would require applying the same change in multiple plugins that use that component. Sounds like a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mik-laj commented on a change in pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #18120:
URL: https://github.com/apache/superset/pull/18120#discussion_r789131031
##########
File path: superset-frontend/src/explore/components/controls/SliderControl.tsx
##########
@@ -17,27 +17,21 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import Slider from 'src/components/Slider';
import ControlHeader from 'src/explore/components/ControlHeader';
-const propTypes = {
- onChange: PropTypes.func,
- value: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
+type SliderControlProps = {
+ onChange: (value: number) => void;
+ value: number;
+ default?: number;
Review comment:
```suggestion
defaultValue?: number;
```
I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #18120: refactor: migrate SliderControl to TypeScript & added story
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #18120:
URL: https://github.com/apache/superset/pull/18120#issuecomment-1017888864
# [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18120](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d03c511) into [master](https://codecov.io/gh/apache/superset/commit/1f8129241ba197a25795f1a9459996df9b696a4c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f81292) will **increase** coverage by `0.22%`.
> The diff coverage is `97.94%`.
> :exclamation: Current head d03c511 differs from pull request most recent head 45947bc. Consider uploading reports for the commit 45947bc to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #18120 +/- ##
==========================================
+ Coverage 65.74% 65.96% +0.22%
==========================================
Files 1577 1584 +7
Lines 61807 62000 +193
Branches 6243 6243
==========================================
+ Hits 40637 40901 +264
+ Misses 19569 19498 -71
Partials 1601 1601
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `50.90% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/controls/SliderControl.tsx](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TbGlkZXJDb250cm9sLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [superset/key\_value/commands/entry.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQva2V5X3ZhbHVlL2NvbW1hbmRzL2VudHJ5LnB5) | `100.00% <ø> (ø)` | |
| [superset/charts/form\_data/commands/update.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS9jb21tYW5kcy91cGRhdGUucHk=) | `90.90% <90.90%> (ø)` | |
| [superset/charts/form\_data/commands/create.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS9jb21tYW5kcy9jcmVhdGUucHk=) | `94.11% <94.11%> (ø)` | |
| [superset/charts/form\_data/commands/delete.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS9jb21tYW5kcy9kZWxldGUucHk=) | `94.73% <94.73%> (ø)` | |
| [superset/charts/form\_data/commands/get.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS9jb21tYW5kcy9nZXQucHk=) | `95.65% <95.65%> (ø)` | |
| [superset/charts/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4Y2VwdGlvbnMucHk=) | `91.48% <100.00%> (+0.37%)` | :arrow_up: |
| [superset/charts/form\_data/api.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS9hcGkucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/charts/form\_data/utils.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2Zvcm1fZGF0YS91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.74% <100.00%> (+0.02%)` | :arrow_up: |
| ... and [19 more](https://codecov.io/gh/apache/superset/pull/18120/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1f81292...45947bc](https://codecov.io/gh/apache/superset/pull/18120?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org