[GitHub] [incubator-inlong] healchow commented on a diff in pull request #4266: [INLONG-4263][Manager] Support hbase sink resource creation

[GitBox <gi...@apache.org>]

healchow commented on code in PR #4266:
URL: https://github.com/apache/incubator-inlong/pull/4266#discussion_r877754440


##########
inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/pojo/sink/SinkFieldBase.java:
##########
@@ -62,4 +62,7 @@ public class SinkFieldBase {
     @ApiModelProperty("Field order")
     private Short rankNum;
 
+    @ApiModelProperty("Column family for columnar storage e.g.hbase")
+    private String columnFamily;

Review Comment:
   Do we really need to add every specified field to the table when using a different type of sink?



##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/SinkInfoUtils.java:
##########
@@ -233,4 +243,19 @@ public static void checkPartitionField(List<? extends SinkFieldBase> fieldList,
         }
     }
 
+    private static HbaseSinkInfo createHbaseSinkInfo(HbaseSinkResponse sinkResponse, List<FieldInfo> sinkFields) {

Review Comment:
   Add Java doc please.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org