[GitHub] [pinot] abhioncbr commented on a diff in pull request #10692: 10688: Handling the Join route parsing

["abhioncbr (via GitHub)" <gi...@apache.org>]

abhioncbr commented on code in PR #10692:
URL: https://github.com/apache/pinot/pull/10692#discussion_r1183179928


##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -199,7 +199,7 @@ public static List<String> extractTableNamesFromNode(SqlNode sqlNode) {
   }
 
   @VisibleForTesting
-  static SqlNodeAndOptions extractSqlNodeAndOptions(String sql, SqlNodeList sqlNodeList) {
+  public static SqlNodeAndOptions extractSqlNodeAndOptions(String sql, SqlNodeList sqlNodeList) {

Review Comment:
   We need this because we are invoking the function from the `Connection` class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org