You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/10/15 09:22:17 UTC

[GitHub] [sling-org-apache-sling-feature-cpconverter] bosschaert commented on a change in pull request #31: SLING-9827 Specify the API Region to export packages into

bosschaert commented on a change in pull request #31:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/31#discussion_r505389906



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/features/DefaultFeaturesManager.java
##########
@@ -225,6 +224,45 @@ public void addConfiguration(String runMode, String pid, Dictionary<String, Obje
         }
     }
 
+    private void addAPIRegions(Feature feature, List<String> exportedPackages) {

Review comment:
       :) this class was already doing it like that - but I'll be happy to improve it to use the API.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org