You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "joyyir (via GitHub)" <gi...@apache.org> on 2023/05/22 04:31:05 UTC
[GitHub] [apisix-java-plugin-runner] joyyir opened a new pull request, #244: bug: `ExtraInfoResponse` class `getResult` method bug
joyyir opened a new pull request, #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
#243
___
### Bugfix
- Description
see #243
- How to fix?
- Instead of casting to `char`, cast to `byte`
- `setBody` with byte array instead of `String`
- `getBody` with `Charset`
___
### New feature or improvement
- Describe the details and related test reports.
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] joyyir commented on pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "joyyir (via GitHub)" <gi...@apache.org>.
joyyir commented on PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244#issuecomment-1556976655
Added a new method while maintaining the original method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen commented on pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "nic-chen (via GitHub)" <gi...@apache.org>.
nic-chen commented on PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244#issuecomment-1556625122
This is a breaking change, even though the original bug existed.
We should add new methods to solve this issue, and then remove the problematic methods in a later version, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen commented on pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "nic-chen (via GitHub)" <gi...@apache.org>.
nic-chen commented on PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244#issuecomment-1562407675
hi @joyyir please fix the failed CI , thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] joyyir commented on pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "joyyir (via GitHub)" <gi...@apache.org>.
joyyir commented on PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244#issuecomment-1556676266
> This is a breaking change, even though the original bug existed.
>
> We should add new methods to solve this issue, and then remove the problematic methods in a later version, what do you think?
I agree. I'll try to write another version, so please review it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] joyyir commented on pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "joyyir (via GitHub)" <gi...@apache.org>.
joyyir commented on PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244#issuecomment-1568157852
> hi @joyyir please fix the failed CI , thanks.
Okay, I've added license header. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen merged pull request #244: bug: `ExtraInfoResponse` class `getResult` method bug
Posted by "nic-chen (via GitHub)" <gi...@apache.org>.
nic-chen merged PR #244:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org