[GitHub] [cassandra] dcapwell commented on a change in pull request #708: CASSANDRA-15977 4.0 quality testing: Read Repair

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #708:
URL: https://github.com/apache/cassandra/pull/708#discussion_r483795774



##########
File path: test/distributed/org/apache/cassandra/distributed/test/TestBaseImpl.java
##########
@@ -43,4 +51,29 @@ public static void beforeClass() throws Throwable {
         // fact that this code is going to work accross _all_ versions.
         return Cluster.build();
     }
+
+    public static Object list(Object...values)
+    {
+        return CQLTester.list(values);
+    }
+
+    public static Object set(Object...values)
+    {
+        return CQLTester.set(values);
+    }
+
+    public static Object map(Object...values)
+    {
+        return CQLTester.map(values);
+    }
+
+    public static ByteBuffer tuple(Object... values)
+    {
+        return CQLTester.tuple(values).toByteBuffer();
+    }
+
+    public static ByteBuffer udt(Object... values)
+    {
+        return CQLTester.userType(values).toByteBuffer();
+    }

Review comment:
       for list, set, and map I would be in favor of removing in favor of `Arrays.asList`, `Sets.newHashSet`, `ImmutableMap.of` as they are type safe and do the same thing; tuple and UDTs are harder to work with so offer more value (namely `org.apache.cassandra.cql3.CQLTester#typeFor` to infer the AbstractType recursively to generate the bb), given this PR though, tuple and UDTs are dead code so maybe we remove until needed?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org