You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Leo Li (JIRA)" <ji...@apache.org> on 2006/12/27 03:46:21 UTC

[jira] Created: (HARMONY-2882) [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

[java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-2882
                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
             Project: Harmony
          Issue Type: Bug
          Components: Classlib
            Reporter: Leo Li


Here is a testcase:

public void testSetDate()
{
   Set taSet = TestUtils.getTrustAnchorSet();
   PKIXParameters p = new PKIXParameters(taSet);
   Date toBeSet = new Date(555L);
   p.setDate(toBeSet);

  p.setDate(null);
  assertEquals(555L, p.getDate().getTime());
}

RI passes.
Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2882) [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stepan Mishura updated HARMONY-2882:
------------------------------------

    Component/s:     (was: Classlib)
                 Non-bug differences from RI

Agreed on the dev list that this is non-bug difference and it won't be fixed.

See:
http://mail-archives.apache.org/mod_mbox/harmony-dev/200701.mbox/%3c6e47b64f0701090339x72ada7d9p1be9122252e814c9@mail.gmail.com%3e

> [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2882) [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2882?page=all ]

Stepan Mishura updated HARMONY-2882:
------------------------------------

    Patch Info: [Patch Available]
       Summary: [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.  (was: [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.)

> [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-2882) [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2882?page=all ]

Leo Li updated HARMONY-2882:
----------------------------

    Attachment: patch-2882.diff

Hi,all:
     Will somebody try this?

Thanks,
Leo.

> [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-2882) [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-2882?page=all ]

Stepan Mishura reassigned HARMONY-2882:
---------------------------------------

    Assignee: Stepan Mishura

> [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-2882) [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stepan Mishura closed HARMONY-2882.
-----------------------------------

    Resolution: Won't Fix

> [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: https://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Non-bug differences from RI
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2882) [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Leo Li (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2882?page=comments#action_12461132 ] 
            
Leo Li commented on HARMONY-2882:
---------------------------------

Hi, Stepan:
      I think it is OK to mark it as non-bug difference since currently we have no indications that application will depend on this behavior.(Actually I agree with you that the currenttime should be set, but RI ...)

Thanks,
Leo.

> [classlib][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-2882) [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-2882?page=comments#action_12460947 ] 
            
Stepan Mishura commented on HARMONY-2882:
-----------------------------------------

Hi Leo,

I think Harmony follows the spec. for PKIXParameters.setDate(Date date). It says:
"public void setDate(Date date)
Sets the time for which the validity of the certification path should be determined. If null, the current time is used..."

My undestanding is: null is a valid parameter and the spec. clearly states that if it is passed to the method the current time is used.
But according to the test in the bug description RI ignores null value (IOW, it doesn't allow to reset it to current time). Please note it accepts any non-null value (IOW, initial 'time' value is not final and it allows to change it) and this looks inconsistent for me.

I'd mark this bug as "Non-bug differences from RI"

Thanks,
Stepan.

> [java][security]PKIXParameters.setDate(null) has no effect on the original date value on RI but Harmony sets it to null.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2882
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2882
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Leo Li
>         Assigned To: Stepan Mishura
>         Attachments: patch-2882.diff
>
>
> Here is a testcase:
> public void testSetDate()
> {
>    Set taSet = TestUtils.getTrustAnchorSet();
>    PKIXParameters p = new PKIXParameters(taSet);
>    Date toBeSet = new Date(555L);
>    p.setDate(toBeSet);
>   p.setDate(null);
>   assertEquals(555L, p.getDate().getTime());
> }
> RI passes.
> Harmony fails.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira