[jira] [Resolved] (DBCP-454) OSGi declarations contain multiple import headers for javax.transaction

["Matt Sicker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/DBCP-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Sicker resolved DBCP-454.
------------------------------
       Resolution: Fixed
    Fix Version/s: 2.2

Fixed in revision 1754999. I gave up on trying to make a pax-exam unit test as it's far too complicated to get working for this type of use case. Right now, the best way to verify that this works is to simply install the jar (and dependencies) to a Karaf container and make sure you can run {{bundle:start}} on it. More proper OSGi tests are included in the [pax-jdbc version|https://github.com/ops4j/org.ops4j.pax.jdbc/tree/master/pax-jdbc-pool-dbcp2] of dbcp2.

> OSGi declarations contain multiple import headers for javax.transaction
> -----------------------------------------------------------------------
>
>                 Key: DBCP-454
>                 URL: https://issues.apache.org/jira/browse/DBCP-454
>             Project: Commons Dbcp
>          Issue Type: Bug
>    Affects Versions: 2.2
>         Environment: OSGi
>            Reporter: Philipp Marx
>            Assignee: Matt Sicker
>            Priority: Blocker
>             Fix For: 2.2
>
>         Attachments: patch
>
>
> In DBCP-445 an issue for "javax.transaction" import-packages was addressed. Though with the fix for this issue the import-packages will contain "javax.transaction" twice:
> Import-Package: javax.management,javax.naming,javax.naming.spi,javax.s
>  ql,javax.transaction,javax.transaction.xa,org.apache.commons.logging,
>  org.apache.commons.pool2,org.apache.commons.pool2.impl,javax.transact
>  ion.xa;version="1.1.0";partial=true;mandatory:=partial,javax.transact
>  ion;version="1.1.0"
> Thus the bundle can't be loaded as duplicate import declarations are prohibited and i.e. Felix will complain about this and refuse to install the bundle. The fix is quite simple by appending the '*' to the end (see attached patch).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)