You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Julien Le Dem (JIRA)" <ji...@apache.org> on 2012/06/11 20:42:44 UTC
[jira] [Created] (PIG-2748) Change the names of the jar produced in
the build folder to match maven conventions
Julien Le Dem created PIG-2748:
----------------------------------
Summary: Change the names of the jar produced in the build folder to match maven conventions
Key: PIG-2748
URL: https://issues.apache.org/jira/browse/PIG-2748
Project: Pig
Issue Type: Bug
Reporter: Julien Le Dem
Assignee: Julien Le Dem
pig-{version}-core.jar becomes pig-{version}.jar
pig-{version}.jar becomes pig-{version}-withdependencies.jar
- <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
+ <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
- <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
+ <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2748) Change the names of the jar produced in
the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2748:
-------------------------------
Attachment: PIG-2748.patch
PIG-2748.patch
suppressed duplicated properties.
renamed properties to match the new naming convention.
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2748.patch
>
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295793#comment-13295793 ]
Julien Le Dem commented on PIG-2748:
------------------------------------
We are already publishing pig-{version}-core.jar as pig-{version}.jar, so this would make things consistent and less confusing. It is also a step in the direction of a more maven friendly build.
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402551#comment-13402551 ]
Daniel Dai commented on PIG-2748:
---------------------------------
+1
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2748.patch
>
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2748) Change the names of the jar produced in
the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2748:
-------------------------------
Description:
{noformat}
pig-{version}-core.jar becomes pig-{version}.jar
pig-{version}.jar becomes pig-{version}-withdependencies.jar
- <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
+ <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
- <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
+ <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
{noformat}
was:
pig-{version}-core.jar becomes pig-{version}.jar
pig-{version}.jar becomes pig-{version}-withdependencies.jar
- <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
+ <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
- <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
+ <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402474#comment-13402474 ]
Julien Le Dem commented on PIG-2748:
------------------------------------
mvn-install works correctly.
mvn-deploy fails with 401 as it should because I'm not authorized to deploy.
Daniel, can you take a quick look ? I'd like to check this in.
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2748.patch
>
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Jonathan Coveney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292976#comment-13292976 ]
Jonathan Coveney commented on PIG-2748:
---------------------------------------
Given that this is apropos of nothing (well, apropos of a much needed conversion to maven which may or may not ever happen), is there a compelling reason to change this? Why not offer a new target with the new names, but keep it as is? I feel like this would break builds for dubious gain.
Though, in theory, I 100% support it.
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2748) Change the names of the jar produced in
the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem updated PIG-2748:
-------------------------------
Patch Info: Patch Available
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Attachments: PIG-2748.patch
>
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Julien Le Dem (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Le Dem resolved PIG-2748.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.11
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
> Fix For: 0.11
>
> Attachments: PIG-2748.patch
>
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2748) Change the names of the jar produced
in the build folder to match maven conventions
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292996#comment-13292996 ]
Daniel Dai commented on PIG-2748:
---------------------------------
Fine as long as we don't change top level pig.jar, pig-withouthadoop.jar. Also need to make sure mvn-install/mvn-deploy is doing the right thing after change.
> Change the names of the jar produced in the build folder to match maven conventions
> -----------------------------------------------------------------------------------
>
> Key: PIG-2748
> URL: https://issues.apache.org/jira/browse/PIG-2748
> Project: Pig
> Issue Type: Bug
> Reporter: Julien Le Dem
> Assignee: Julien Le Dem
>
> {noformat}
> pig-{version}-core.jar becomes pig-{version}.jar
> pig-{version}.jar becomes pig-{version}-withdependencies.jar
> - <property name="output.jarfile" value="${build.dir}/${final.name}.jar" />
> + <property name="output.jarfile" value="${build.dir}/${final.name}-withdependencies.jar" />
> - <property name="output.jarfile.core" value="${build.dir}/${final.name}-core.jar" />
> + <property name="output.jarfile.core" value="${build.dir}/${final.name}.jar" />
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira