[GitHub] [shardingsphere] tristaZero commented on issue #8570: shardingsphere-jdbc-governance incompatible with HikariCP >= 3.4.3

[GitBox <gi...@apache.org>]

tristaZero commented on issue #8570:
URL: https://github.com/apache/shardingsphere/issues/8570#issuecomment-742954072


   Hi @TeslaCN ,
   
   Thanks for this issue. I suppose it is a bug. Do you have any idea to solve this one?
   Here is a quick intro concerning converting a `DataSource` to a **Literal** `DataSource` saved in the registry later. We can consider fixing it in `DataSourceConfiguration.java` or `DataSourceConfigurationYamlSwapper.java`.
   
   A `dataSource` will firstly be converted to [DataSourceConfiguration](https://github.com/apache/shardingsphere/blob/master/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/datasource/DataSourceConfiguration.java), and then its  **Literal**  value will be generated by [DataSourceConfigurationYamlSwapper](https://github.com/apache/shardingsphere/blob/master/shardingsphere-governance/shardingsphere-governance-core/src/main/java/org/apache/shardingsphere/governance/core/yaml/swapper/DataSourceConfigurationYamlSwapper.java).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org