You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:19:28 UTC
[GitHub] [logging-log4j2] sman-81 opened a new pull request #522: LOG4J2-3107
sman-81 opened a new pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522
@vy I've reiterated the fix using your suggestions.
It also contains a unit test.
NameUtil.md5 is gone from the implementation, as I see no use in it and its presence complicates testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on pull request #522: LOG4J2-3107
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522#issuecomment-864378237
>
>
> Something is very wrong with this PR. It has merge conflicts and impacts way too many files.
My fix for LOG4J2-3107 changes two files and adds one. The change should be targeted at the release-2.x branch, rather than master.
I agree with you this pull request is wrong.
I'll close it and submit another after reviewing where it might have gone wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 closed pull request #522: LOG4J2-3107
Posted by GitBox <gi...@apache.org>.
sman-81 closed pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] sman-81 commented on pull request #522: LOG4J2-3107
Posted by GitBox <gi...@apache.org>.
sman-81 commented on pull request #522:
URL: https://github.com/apache/logging-log4j2/pull/522#issuecomment-866121545
Hello @rgoers, I have submitted a corrected PR this afternoon, that goes against the release branch not master.
Have a good evening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org