You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by belliraj hb <be...@gmail.com> on 2017/02/07 11:55:14 UTC
Review Request 56383: AMBARI-19889:Workflow Manager Should be able to
handle fork with single path.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56383/
-----------------------------------------------------------
Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-19889
https://issues.apache.org/jira/browse/AMBARI-19889
Repository: ambari
Description
-------
The fix was to make changes to find node for fork. Also if the import is a simple object instead of array, we convert to array.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/domain/findnode-mixin.js c770fb023b
contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 28ea5278a1
contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js db5bf1e996
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 900d692fac
Diff: https://reviews.apache.org/r/56383/diff/
Testing
-------
Manual Testing
Thanks,
belliraj hb
Re: Review Request 56383: AMBARI-19889:Workflow Manager Should be
able to handle fork with single path.
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56383/#review164495
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 7, 2017, 11:55 a.m., belliraj hb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56383/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:55 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19889
> https://issues.apache.org/jira/browse/AMBARI-19889
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The fix was to make changes to find node for fork. Also if the import is a simple object instead of array, we convert to array.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/findnode-mixin.js c770fb023b
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 28ea5278a1
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js db5bf1e996
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 900d692fac
>
> Diff: https://reviews.apache.org/r/56383/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> belliraj hb
>
>
Re: Review Request 56383: AMBARI-19889:Workflow Manager Should be
able to handle fork with single path.
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56383/#review164663
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 7, 2017, 11:55 a.m., belliraj hb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56383/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 11:55 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-19889
> https://issues.apache.org/jira/browse/AMBARI-19889
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The fix was to make changes to find node for fork. Also if the import is a simple object instead of array, we convert to array.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/domain/findnode-mixin.js c770fb023b
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js 28ea5278a1
> contrib/views/wfmanager/src/main/resources/ui/app/domain/node.js db5bf1e996
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 900d692fac
>
> Diff: https://reviews.apache.org/r/56383/diff/
>
>
> Testing
> -------
>
> Manual Testing
>
>
> Thanks,
>
> belliraj hb
>
>