[jira] [Commented] (HBASE-11983) HRegion constructors should not create HLog

["Nick Dimiduk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252288#comment-14252288 ] 

Nick Dimiduk commented on HBASE-11983:
--------------------------------------

Reading over the description again, my patch is a subset of what's described. I'm hoping this will reduce our test suite leaking file handles though. More needs done to fixup the create vs open APIs.

> HRegion constructors should not create HLog 
> --------------------------------------------
>
>                 Key: HBASE-11983
>                 URL: https://issues.apache.org/jira/browse/HBASE-11983
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>            Reporter: Enis Soztutar
>            Assignee: Nick Dimiduk
>              Labels: beginner
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11983.00.patch
>
>
> We should get rid of HRegion creating its own HLog. It should ALWAYS get the log from outside. 
> I think this was added for unit tests, but we should refrain from such practice in the future (adding UT constructors always leads to weird and critical bugs down the road). See recent: HBASE-11982, HBASE-11654. 
> Get rid of weird things like ignoreHLog:
> {code}
>   /**
>    * @param ignoreHLog - true to skip generate new hlog if it is null, mostly for createTable
>    */
>   public static HRegion createHRegion(final HRegionInfo info, final Path rootDir,
>                                       final Configuration conf,
>                                       final HTableDescriptor hTableDescriptor,
>                                       final HLog hlog,
>                                       final boolean initialize, final boolean ignoreHLog)
> {code}
> We can unify all the createXX and newXX methods and separate creating a region in the file system vs opening a region. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)