You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gengliangwang (via GitHub)" <gi...@apache.org> on 2024/05/20 19:58:49 UTC
Re: [PR] [SPARK-43815][SQL] Wrap NPE with AnalysisException in CSV, XML, and JSON options [spark]
gengliangwang commented on code in PR #46626:
URL: https://github.com/apache/spark/pull/46626#discussion_r1607213012
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala:
##########
@@ -107,7 +108,13 @@ class JSONOptions(
val writeNullIfWithDefaultValue = SQLConf.get.jsonWriteNullIfWithDefaultValue
// A language tag in IETF BCP 47 format
- val locale: Locale = parameters.get(LOCALE).map(Locale.forLanguageTag).getOrElse(Locale.US)
+ val locale: Locale = parameters.get(LOCALE)
Review Comment:
Let's reduce the duplicated code in CSV/JSON/XML options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org