You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2021/05/28 15:35:40 UTC
[james-mime4j] branch master updated (2fe9d4d -> 2a67295)
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git.
from 2fe9d4d Merge pull request #17 from bwndai/encodeQ
new 33f62c6 [WARNING] Remove unused import
new 4a4be4b [WARNING] MessageBuilder::getReadDate infinitely recurse
new f9d84f6 [WARNING] Remove uneeded redundant interface qualifiers
new 66bb16c [WARNING] Unneeded array boxing
new 7cabf17 [WARNING] Manual calls to Math.max
new f86273e [WARNING] Group: iterations can be replaces by Collection::addAll
new 2a67295 [WARNING] Remove unecessary toString calls
The 7 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/james/mime4j/stream/ParserCursor.java | 6 +++---
.../james/mime4j/io/EOLConvertingInputStreamTest.java | 6 +++---
.../main/java/org/apache/james/mime4j/dom/Multipart.java | 2 +-
.../java/org/apache/james/mime4j/dom/address/Group.java | 4 +---
.../james/mime4j/dom/field/ContentDispositionField.java | 14 +++++++-------
.../apache/james/mime4j/dom/field/ContentTypeField.java | 12 ++++++------
.../james/mime4j/internal/AbstractEntityBuilder.java | 1 -
.../org/apache/james/mime4j/message/MessageBuilder.java | 3 +--
.../org/apache/james/mime4j/message/SingleBodyBuilder.java | 1 -
.../mime4j/field/address/DefaultAddressFormatterTest.java | 2 +-
.../james/mime4j/message/AbstractEntityBuilderTest.java | 1 -
.../james/mime4j/mboxiterator/CharBufferWrapper.java | 1 -
.../apache/james/mime4j/mboxiterator/FromLinePatterns.java | 4 ++--
.../org/apache/james/mime4j/mboxiterator/MboxIterator.java | 3 ---
.../mime4j/mboxiterator/ByteBufferInputStreamTest.java | 1 -
.../org/apache/james/mime4j/storage/StorageBinaryBody.java | 1 -
16 files changed, 25 insertions(+), 37 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 03/07: [WARNING] Remove uneeded redundant interface
qualifiers
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit f9d84f626623c956029594ae4ea04c6078ca2cfe
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:43:26 2021 +0700
[WARNING] Remove uneeded redundant interface qualifiers
Idem, this was reported by intelliJ inspections.
---
.../main/java/org/apache/james/mime4j/dom/Multipart.java | 2 +-
.../james/mime4j/dom/field/ContentDispositionField.java | 14 +++++++-------
.../apache/james/mime4j/dom/field/ContentTypeField.java | 12 ++++++------
.../apache/james/mime4j/mboxiterator/FromLinePatterns.java | 4 ++--
4 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java b/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
index 98d9399..1685cd5 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/Multipart.java
@@ -52,7 +52,7 @@ public interface Multipart extends Body {
*
* @return the list of <code>Entity</code> objects.
*/
- public List<Entity> getBodyParts();
+ List<Entity> getBodyParts();
/**
* Sets the list of body parts.
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
index 7e2961e..3a0699c 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentDispositionField.java
@@ -25,19 +25,19 @@ import java.util.Map;
public interface ContentDispositionField extends ParsedField {
/** The <code>inline</code> disposition type. */
- public static final String DISPOSITION_TYPE_INLINE = "inline";
+ String DISPOSITION_TYPE_INLINE = "inline";
/** The <code>attachment</code> disposition type. */
- public static final String DISPOSITION_TYPE_ATTACHMENT = "attachment";
+ String DISPOSITION_TYPE_ATTACHMENT = "attachment";
/** The name of the <code>filename</code> parameter. */
- public static final String PARAM_FILENAME = "filename";
+ String PARAM_FILENAME = "filename";
/** The name of the <code>creation-date</code> parameter. */
- public static final String PARAM_CREATION_DATE = "creation-date";
+ String PARAM_CREATION_DATE = "creation-date";
/** The name of the <code>modification-date</code> parameter. */
- public static final String PARAM_MODIFICATION_DATE = "modification-date";
+ String PARAM_MODIFICATION_DATE = "modification-date";
/** The name of the <code>read-date</code> parameter. */
- public static final String PARAM_READ_DATE = "read-date";
+ String PARAM_READ_DATE = "read-date";
/** The name of the <code>size</code> parameter. */
- public static final String PARAM_SIZE = "size";
+ String PARAM_SIZE = "size";
/**
* Gets the disposition type defined in this Content-Disposition field.
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
index 1885060..2a5670f 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/field/ContentTypeField.java
@@ -24,17 +24,17 @@ import java.util.Map;
public interface ContentTypeField extends ParsedField {
/** The prefix of all <code>multipart</code> MIME types. */
- public static final String TYPE_MULTIPART_PREFIX = "multipart/";
+ String TYPE_MULTIPART_PREFIX = "multipart/";
/** The <code>multipart/digest</code> MIME type. */
- public static final String TYPE_MULTIPART_DIGEST = "multipart/digest";
+ String TYPE_MULTIPART_DIGEST = "multipart/digest";
/** The <code>text/plain</code> MIME type. */
- public static final String TYPE_TEXT_PLAIN = "text/plain";
+ String TYPE_TEXT_PLAIN = "text/plain";
/** The <code>message/rfc822</code> MIME type. */
- public static final String TYPE_MESSAGE_RFC822 = "message/rfc822";
+ String TYPE_MESSAGE_RFC822 = "message/rfc822";
/** The name of the <code>boundary</code> parameter. */
- public static final String PARAM_BOUNDARY = "boundary";
+ String PARAM_BOUNDARY = "boundary";
/** The name of the <code>charset</code> parameter. */
- public static final String PARAM_CHARSET = "charset";
+ String PARAM_CHARSET = "charset";
/**
* Gets the MIME type defined in this Content-Type field.
diff --git a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
index 3087472..73486f7 100644
--- a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
+++ b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/FromLinePatterns.java
@@ -28,13 +28,13 @@ public interface FromLinePatterns {
/**
* Match a line like: From ieugen@apache.org Fri Sep 09 14:04:52 2011
*/
- static final String DEFAULT = "^From \\S+@\\S.*\\d{4}$";
+ String DEFAULT = "^From \\S+@\\S.*\\d{4}$";
/**
* Matches other type of From_ line (without @):
* From MAILER-DAEMON Wed Oct 05 21:54:09 2011
* Thunderbird mbox content: From - Wed Apr 02 06:51:08 2014
*/
- static final String DEFAULT2 = "^From \\S+.*\\d{4}$";
+ String DEFAULT2 = "^From \\S+.*\\d{4}$";
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 06/07: [WARNING] Group: iterations can be replaces
by Collection::addAll
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit f86273ef1d960dde553f9be205721a9e0cde1446
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:46:13 2021 +0700
[WARNING] Group: iterations can be replaces by Collection::addAll
This is likely to be more efficient.
---
dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java b/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
index 14b1433..1da7939 100644
--- a/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
+++ b/dom/src/main/java/org/apache/james/mime4j/dom/address/Group.java
@@ -86,9 +86,7 @@ public class Group extends Address {
@Override
protected void doAddMailboxesTo(List<Mailbox> results) {
- for (Mailbox mailbox : mailboxList) {
- results.add(mailbox);
- }
+ results.addAll(mailboxList);
}
@Override
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 05/07: [WARNING] Manual calls to Math.max
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit 7cabf17f4b8bdd4944b2f4c3685effd53c233da7
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:45:27 2021 +0700
[WARNING] Manual calls to Math.max
Using Math.max is more explicit and thus
should be favored.
---
.../org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java b/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
index 116bae5..ce55b2d 100644
--- a/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
+++ b/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
@@ -69,7 +69,7 @@ public class EOLConvertingInputStreamTest {
new EOLConvertingInputStream(InputStreams.createAscii(s1),
EOLConvertingInputStream.CONVERT_BOTH);
int n = in.read(bytes);
- Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n : 0));
+ Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, Math.max(n, 0)));
in.close();
}
@@ -81,7 +81,7 @@ public class EOLConvertingInputStreamTest {
new EOLConvertingInputStream(InputStreams.createAscii(s1),
EOLConvertingInputStream.CONVERT_CR);
int n = in.read(bytes);
- Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n : 0));
+ Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, Math.max(n, 0)));
in.close();
}
@@ -93,7 +93,7 @@ public class EOLConvertingInputStreamTest {
new EOLConvertingInputStream(InputStreams.createAscii(s1),
EOLConvertingInputStream.CONVERT_LF);
int n = in.read(bytes);
- Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n : 0));
+ Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, Math.max(n, 0)));
in.close();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 02/07: [WARNING] MessageBuilder::getReadDate
infinitely recurse
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit 4a4be4b0ccd448f8eb9bde379fbb9b1ec3bff72e
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:42:28 2021 +0700
[WARNING] MessageBuilder::getReadDate infinitely recurse
This was reported by intelliJ as "likely a bug".
There is no shortcut to exit this infinite recursion.
The pattern applied with MIME4J-262, that is
to call the same method on the delegate
builder is not followed.
---
dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java b/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
index 1478c39..398b093 100644
--- a/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
+++ b/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
@@ -267,7 +267,7 @@ public class MessageBuilder {
}
public Date getReadDate() {
- return getReadDate();
+ return builder.getReadDate();
}
public String getMessageId() {
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 04/07: [WARNING] Unneeded array boxing
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit 66bb16ce79295d9af09f685ed610e925d779c2fa
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:44:34 2021 +0700
[WARNING] Unneeded array boxing
---
.../apache/james/mime4j/field/address/DefaultAddressFormatterTest.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dom/src/test/java/org/apache/james/mime4j/field/address/DefaultAddressFormatterTest.java b/dom/src/test/java/org/apache/james/mime4j/field/address/DefaultAddressFormatterTest.java
index 835bff8..a56ff50 100644
--- a/dom/src/test/java/org/apache/james/mime4j/field/address/DefaultAddressFormatterTest.java
+++ b/dom/src/test/java/org/apache/james/mime4j/field/address/DefaultAddressFormatterTest.java
@@ -46,7 +46,7 @@ public class DefaultAddressFormatterTest {
al.add(new Mailbox("test", "example.com"));
al.add(new Mailbox("Foo!", "foo", "example.com"));
DomainList dl = new DomainList(new ArrayList<String>(
- Arrays.asList(new String[]{"foo.example.com"})));
+ Arrays.asList("foo.example.com")));
Mailbox mailbox = new Mailbox("Foo Bar", dl, "foo2", "example.com");
Assert.assertSame(dl, mailbox.getRoute());
al.add(mailbox);
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 07/07: [WARNING] Remove unecessary toString calls
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit 2a67295206b3dd3457fa4277c78f2485f0b80c63
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:46:56 2021 +0700
[WARNING] Remove unecessary toString calls
The StringBuilder handles the conversion
itself.
---
core/src/main/java/org/apache/james/mime4j/stream/ParserCursor.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/core/src/main/java/org/apache/james/mime4j/stream/ParserCursor.java b/core/src/main/java/org/apache/james/mime4j/stream/ParserCursor.java
index edb475e..0a5e2ab 100644
--- a/core/src/main/java/org/apache/james/mime4j/stream/ParserCursor.java
+++ b/core/src/main/java/org/apache/james/mime4j/stream/ParserCursor.java
@@ -79,11 +79,11 @@ public class ParserCursor {
public String toString() {
StringBuilder buffer = new StringBuilder();
buffer.append('[');
- buffer.append(Integer.toString(this.lowerBound));
+ buffer.append(this.lowerBound);
buffer.append('>');
- buffer.append(Integer.toString(this.pos));
+ buffer.append(this.pos);
buffer.append('>');
- buffer.append(Integer.toString(this.upperBound));
+ buffer.append(this.upperBound);
buffer.append(']');
return buffer.toString();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[james-mime4j] 01/07: [WARNING] Remove unused import
Posted by bt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit 33f62c6a5c6973999430f1afe37cbe9bcffe26c0
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Thu May 27 14:37:51 2021 +0700
[WARNING] Remove unused import
Run intelliJ inspection to find unused imports
---
.../java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java | 1 -
dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java | 1 -
.../main/java/org/apache/james/mime4j/message/SingleBodyBuilder.java | 1 -
.../org/apache/james/mime4j/message/AbstractEntityBuilderTest.java | 1 -
.../java/org/apache/james/mime4j/mboxiterator/CharBufferWrapper.java | 1 -
.../main/java/org/apache/james/mime4j/mboxiterator/MboxIterator.java | 3 ---
.../apache/james/mime4j/mboxiterator/ByteBufferInputStreamTest.java | 1 -
.../main/java/org/apache/james/mime4j/storage/StorageBinaryBody.java | 1 -
8 files changed, 10 deletions(-)
diff --git a/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java b/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
index 5561c5a..5b83625 100644
--- a/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
+++ b/dom/src/main/java/org/apache/james/mime4j/internal/AbstractEntityBuilder.java
@@ -41,7 +41,6 @@ import org.apache.james.mime4j.dom.field.ContentTypeField;
import org.apache.james.mime4j.dom.field.FieldName;
import org.apache.james.mime4j.dom.field.ParsedField;
import org.apache.james.mime4j.field.Fields;
-import org.apache.james.mime4j.message.BodyPartBuilder;
import org.apache.james.mime4j.message.MultipartBuilder;
import org.apache.james.mime4j.message.SingleBodyBuilder;
import org.apache.james.mime4j.stream.Field;
diff --git a/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java b/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
index 50a554b..1478c39 100644
--- a/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
+++ b/dom/src/main/java/org/apache/james/mime4j/message/MessageBuilder.java
@@ -31,7 +31,6 @@ import org.apache.james.mime4j.dom.address.AddressList;
import org.apache.james.mime4j.dom.address.Mailbox;
import org.apache.james.mime4j.dom.address.MailboxList;
import org.apache.james.mime4j.dom.field.ParseException;
-import org.apache.james.mime4j.dom.field.ParsedField;
import org.apache.james.mime4j.stream.BodyDescriptorBuilder;
import org.apache.james.mime4j.stream.Field;
import org.apache.james.mime4j.stream.MimeConfig;
diff --git a/dom/src/main/java/org/apache/james/mime4j/message/SingleBodyBuilder.java b/dom/src/main/java/org/apache/james/mime4j/message/SingleBodyBuilder.java
index eed1a72..66d99ca 100644
--- a/dom/src/main/java/org/apache/james/mime4j/message/SingleBodyBuilder.java
+++ b/dom/src/main/java/org/apache/james/mime4j/message/SingleBodyBuilder.java
@@ -32,7 +32,6 @@ import org.apache.james.mime4j.dom.BinaryBody;
import org.apache.james.mime4j.dom.SingleBody;
import org.apache.james.mime4j.dom.TextBody;
import org.apache.james.mime4j.io.InputStreams;
-import org.apache.james.mime4j.util.CharsetUtil;
import org.apache.james.mime4j.util.ContentUtil;
/**
diff --git a/dom/src/test/java/org/apache/james/mime4j/message/AbstractEntityBuilderTest.java b/dom/src/test/java/org/apache/james/mime4j/message/AbstractEntityBuilderTest.java
index c7493da..f987115 100644
--- a/dom/src/test/java/org/apache/james/mime4j/message/AbstractEntityBuilderTest.java
+++ b/dom/src/test/java/org/apache/james/mime4j/message/AbstractEntityBuilderTest.java
@@ -20,7 +20,6 @@
package org.apache.james.mime4j.message;
import java.text.SimpleDateFormat;
-import java.util.Arrays;
import java.util.Collections;
import java.util.Date;
import java.util.List;
diff --git a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/CharBufferWrapper.java b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/CharBufferWrapper.java
index 4f85d1f..a91dda6 100644
--- a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/CharBufferWrapper.java
+++ b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/CharBufferWrapper.java
@@ -23,7 +23,6 @@ import java.io.InputStream;
import java.nio.ByteBuffer;
import java.nio.CharBuffer;
import java.nio.charset.Charset;
-import java.util.Objects;
/**
* Wraps a CharBuffer and exposes some convenience methods to easy parse with Mime4j.
diff --git a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/MboxIterator.java b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/MboxIterator.java
index 2e93701..1b81019 100644
--- a/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/MboxIterator.java
+++ b/mbox/src/main/java/org/apache/james/mime4j/mboxiterator/MboxIterator.java
@@ -21,18 +21,15 @@ package org.apache.james.mime4j.mboxiterator;
import java.io.CharConversionException;
import java.io.Closeable;
import java.io.File;
-import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.IOException;
import java.nio.Buffer;
import java.nio.ByteBuffer;
import java.nio.CharBuffer;
-import java.nio.MappedByteBuffer;
import java.nio.channels.FileChannel;
import java.nio.charset.Charset;
import java.nio.charset.CharsetDecoder;
import java.nio.charset.CoderResult;
-import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardOpenOption;
import java.util.Iterator;
diff --git a/mbox/src/test/java/org/apache/james/mime4j/mboxiterator/ByteBufferInputStreamTest.java b/mbox/src/test/java/org/apache/james/mime4j/mboxiterator/ByteBufferInputStreamTest.java
index 388743b..14d6927 100644
--- a/mbox/src/test/java/org/apache/james/mime4j/mboxiterator/ByteBufferInputStreamTest.java
+++ b/mbox/src/test/java/org/apache/james/mime4j/mboxiterator/ByteBufferInputStreamTest.java
@@ -23,7 +23,6 @@ import org.junit.Test;
import java.io.IOException;
import java.io.InputStream;
-import java.nio.ByteBuffer;
import java.nio.CharBuffer;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
diff --git a/storage/src/main/java/org/apache/james/mime4j/storage/StorageBinaryBody.java b/storage/src/main/java/org/apache/james/mime4j/storage/StorageBinaryBody.java
index 1bd7c71..b8a3fcb 100644
--- a/storage/src/main/java/org/apache/james/mime4j/storage/StorageBinaryBody.java
+++ b/storage/src/main/java/org/apache/james/mime4j/storage/StorageBinaryBody.java
@@ -25,7 +25,6 @@ import java.io.OutputStream;
import org.apache.james.mime4j.dom.BinaryBody;
import org.apache.james.mime4j.util.ContentUtil;
-;
/**
* Binary body backed by a
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org