You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/12/31 09:12:34 UTC
[GitHub] [fineract] BLasan opened a new pull request #1787: Transfer Funds from Savings to Share
BLasan opened a new pull request #1787:
URL: https://github.com/apache/fineract/pull/1787
## Description
See [Issue-791](https://issues.apache.org/jira/browse/FINERACT-791)
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-899280058
> This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
Need a review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-923993738
> HI @BLasan - code looks good, but there's a merge conflict and the build was failing. Would you be able to sort these out, and squash the commits please - and we can then merge this. Thanks!
I'll do the refinements. Thanks :) Will you be able to review the post dated checks PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-1026338464
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-938112096
Is there a unit test for this feature? Seems this has conflicts now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-942674564
> PR looks good. Please include an integration test. Unnecessary migration script renames are there.
There's a `mysql join table issue (61 tables)` which is not allowed. This occurs when running the integration tests. Functional wise, it worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-874221069
@thesmallstar Please review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-989328942
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-874221069
@thesmallstar Please review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-899275317
@thesmallstar Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-899132531
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-938290823
> Is there a unit test for this feature? Seems this has conflicts now...
I'll update the PR soon. Found a way to avoid this `mysql join` issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1787:
URL: https://github.com/apache/fineract/pull/1787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-938112096
Is there a unit test for this feature? Seems this has conflicts now...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-933766179
Hi @ptuomola, there's an issue related to the changes I've made. `Too many tables; MySQL can only use 61 tables in a join`. Only added an additional column to keep track of share account in transactions. Do we need to move that implementation to a separate table? Or do you have any suggestion to avoid that issue? I was not able to come up with an answer for that after doing numerous investigations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-962885128
Is your database up and working? The below suggests that the server can’t
connect to the database.
On Mon, 8 Nov 2021 at 3:35 PM, Benura Abeywardena ***@***.***>
wrote:
> Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.security.authenticationManager': Cannot resolve reference to bean 'customAuthenticationProvider' while setting constructor argument with key [0]; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'customAuthenticationProvider' defined in URL [file:/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/META-INF/spring/securityContext.xml]: Cannot resolve reference to bean 'userDetailsService' while setting bean property 'userDetailsService'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'userDetailsService': Unsatisfied dependency expressed through field 'platformUserRepository'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'appUserRepository' defined in org.ap
ache.fineract.useradministration.domain.AppUserRepository defined in : Cannot create inner bean '(inner bean)#a120b9' of type [org.springframework.orm.jpa.SharedEntityManagerCreator] while setting bean property 'entityManager'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name '(inner bean)#a120b9': Cannot resolve reference to bean 'entityManagerFactory' while setting constructor argument; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'tenantDatabaseUpgradeService' defined in file [/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/org/apache/fineract/infrastructure/core/service/TenantDatabaseUpgradeService.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'jdbcTenantDetailsService' defined in file [
/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/org/apache/fineract/infrastructure/security/service/JdbcTenantDetailsService.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'hikariTenantDataSource' defined in URL [file:/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/META-INF/spring/hikariDataSource.xml]: Bean instantiation via constructor failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.zaxxer.hikari.HikariDataSource]: Constructor threw exception; nested exception is com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Could not connect: Connection refused
>
> I'm getting this error when running the PR now. Earlier it was working fine
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1787#issuecomment-962883436>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AASJVCTSDPBXFLOM6JXBS63UK54UBANCNFSM473AALUA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-1003317803
Seeing if I can retrigger the build to see if it passes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-923992123
HI @BLasan - code looks good, but there's a merge conflict and the build was failing. Would you be able to sort these out, and squash the commits please - and we can then merge this. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] BLasan commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-962883436
```
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'org.springframework.security.authenticationManager': Cannot resolve reference to bean 'customAuthenticationProvider' while setting constructor argument with key [0]; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'customAuthenticationProvider' defined in URL [file:/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/META-INF/spring/securityContext.xml]: Cannot resolve reference to bean 'userDetailsService' while setting bean property 'userDetailsService'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'userDetailsService': Unsatisfied dependency expressed through field 'platformUserRepository'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'appUserRepository' defined in org.apac
he.fineract.useradministration.domain.AppUserRepository defined in : Cannot create inner bean '(inner bean)#a120b9' of type [org.springframework.orm.jpa.SharedEntityManagerCreator] while setting bean property 'entityManager'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name '(inner bean)#a120b9': Cannot resolve reference to bean 'entityManagerFactory' while setting constructor argument; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'tenantDatabaseUpgradeService' defined in file [/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/org/apache/fineract/infrastructure/core/service/TenantDatabaseUpgradeService.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'jdbcTenantDetailsService' defined in file [/h
ome/benura/Desktop/fineract/fineract-provider/build/classes/java/main/org/apache/fineract/infrastructure/security/service/JdbcTenantDetailsService.class]: Unsatisfied dependency expressed through constructor parameter 0; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'hikariTenantDataSource' defined in URL [file:/home/benura/Desktop/fineract/fineract-provider/build/classes/java/main/META-INF/spring/hikariDataSource.xml]: Bean instantiation via constructor failed; nested exception is org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.zaxxer.hikari.HikariDataSource]: Constructor threw exception; nested exception is com.zaxxer.hikari.pool.HikariPool$PoolInitializationException: Failed to initialize pool: Could not connect: Connection refused
```
I'm getting this error when running the PR now. Earlier it was working fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1787:
URL: https://github.com/apache/fineract/pull/1787#issuecomment-922391776
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola closed pull request #1787: Transfer Funds from Savings to Share
Posted by GitBox <gi...@apache.org>.
ptuomola closed pull request #1787:
URL: https://github.com/apache/fineract/pull/1787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org