You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by ag...@apache.org on 2018/04/13 09:34:01 UTC
[49/54] [abbrv] ignite git commit: IGNITE-8141 Acknowledge SWAPPINESS
reduction using a range (<= 10). - Fixes #3727.
IGNITE-8141 Acknowledge SWAPPINESS reduction using a range (<= 10). - Fixes #3727.
Signed-off-by: dpavlov <dp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/ignite/repo
Commit: http://git-wip-us.apache.org/repos/asf/ignite/commit/47ca3e0d
Tree: http://git-wip-us.apache.org/repos/asf/ignite/tree/47ca3e0d
Diff: http://git-wip-us.apache.org/repos/asf/ignite/diff/47ca3e0d
Branch: refs/heads/ignite-6083
Commit: 47ca3e0da7fd7468d7ea96ff512c3d1f3ed5bf81
Parents: b93595c
Author: Reed Sandberg <re...@drawbridge.com>
Authored: Thu Apr 12 20:18:10 2018 +0300
Committer: dpavlov <dp...@apache.org>
Committed: Thu Apr 12 20:18:10 2018 +0300
----------------------------------------------------------------------
.../suggestions/OsConfigurationSuggestions.java | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ignite/blob/47ca3e0d/modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
----------------------------------------------------------------------
diff --git a/modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java b/modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
index e5b4c12..695b423 100644
--- a/modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
+++ b/modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
@@ -76,8 +76,18 @@ public class OsConfigurationSuggestions {
(dwcParamFlag && decParamFlag ? "s" : ""),
expected));
- if ((value = readVmParam(SWAPPINESS)) != null && !value.equals(expected = "10"))
- suggestions.add(String.format("Reduce pages swapping ratio (set vm.%s=%s)", SWAPPINESS, expected));
+ if ((value = readVmParam(SWAPPINESS)) != null) {
+ try {
+ double maxSwappiness = 10.0;
+
+ if (Float.parseFloat(value) > maxSwappiness)
+ suggestions.add(String.format("Reduce pages swapping ratio (set vm.%s=%f or less)", SWAPPINESS,
+ maxSwappiness));
+ }
+ catch (NumberFormatException ignored) {
+ // OS param not parsable as a number
+ }
+ }
if ((value = readVmParam(ZONE_RECLAIM_MODE)) != null && !value.equals(expected = "0"))
suggestions.add(String.format("Disable NUMA memory reclaim (set vm.%s=%s)", ZONE_RECLAIM_MODE,