You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/09/26 06:37:31 UTC
[GitHub] [spark] mskapilks opened a new pull request, #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
mskapilks opened a new pull request, #37996:
URL: https://github.com/apache/spark/pull/37996
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently we allow only a specific pattern in bloom creation side plan (consecutive Filter/Project/Scan nodes) with added column pruning. This is fine when bloom was added due to a BroadcastHashJoin as exchange side would be small and we can do extra scan while creating bloom.
But when Bloom is introduced though SortMergeJoin (Shuffle Join) the exchange can be bigger, and extra scan and other operators can incur cost. In this case we can take advantage of reusing the whole Exchange while creating bloom.
This can further allow complex plans in bloom creation plan as there won't be extra cost of running them twice.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Add Reusable exchange on Bloom creation side plan to improve query performance.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mskapilks commented on pull request #37996: [WIP][SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
mskapilks commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1257783605
Example
|Before|After|
|------|------|
|||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mskapilks commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
mskapilks commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1257789176
cc: @wangyum @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
sigmod commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1258522623
cc @andylam-db @maryannxue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1258485849
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1258025933
Reuse exchange has two advantages:
1. Reduce table scan.
2. We can use `shuffle records written` instead of `spark.sql.optimizer.runtime.bloomFilter.expectedNumItems` to build bloom filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1382978610
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mskapilks commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
mskapilks commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1259015446
> 2. We can use `shuffle records written` instead of `spark.sql.optimizer.runtime.bloomFilter.expectedNumItems` to build bloom filter.
Good point. It would be better than current stats based row count we are using to create bloom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
URL: https://github.com/apache/spark/pull/37996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1261697253
Another advantage is that we can coalesce into smaller partitions and then build the bloom filter because large parallelism can not improve the performance of the build bloom filter. For example:
<img width="618" alt="image" src="https://user-images.githubusercontent.com/5399861/192930789-04fa9f0d-9c18-4b10-951d-804e357948fd.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1257894432
also cc @sigmod
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] holdenk commented on pull request #37996: [SPARK-40558][SQL] Add Reusable Exchange in Bloom creation side plan
Posted by GitBox <gi...@apache.org>.
holdenk commented on PR #37996:
URL: https://github.com/apache/spark/pull/37996#issuecomment-1270679605
Since it's a change to improve performance do we have an idea of what the performance improvement might look like? Looks like you've already run some sample queries so just numbers from that is probably good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org