[GitHub] [iceberg] jackye1995 commented on a change in pull request #1857: rewrite equals filters

[GitBox <gi...@apache.org>]

jackye1995 commented on a change in pull request #1857:
URL: https://github.com/apache/iceberg/pull/1857#discussion_r536375417



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -113,13 +115,13 @@ public static Expression convert(Filter filter) {
             // comparison with null in normal equality is always null. this is probably a mistake.
             Preconditions.checkNotNull(eq.value(),
                 "Expression is always false (eq is not null-safe): %s", filter);
-            return equal(eq.attribute(), convertLiteral(eq.value()));
+            return handleEqual(eq.attribute(), eq.value());
           } else {
             EqualNullSafe eq = (EqualNullSafe) filter;
             if (eq.value() == null) {
               return isNull(eq.attribute());
             } else {
-              return equal(eq.attribute(), convertLiteral(eq.value()));
+              return handleEqual(eq.attribute(), eq.value());

Review comment:
       why is this not directly inside `Expressions.equal`, so we can avoid duplication between spark 2 and 3?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org