[GitHub] rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+

[GitBox <gi...@apache.org>]

rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r158563608
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
 ##########
 @@ -529,13 +540,12 @@ public boolean processCommands(long agentId, long seq, Command[] commands) {
     }
 
     private void createXsToolsISO() {
-        String isoName = "xs-tools.iso";
-        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(isoName);
+        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(_toolsIsoName);
 
 Review comment:
   I would start with a different question. Do we need to check which XenServers versions are used? I mean, Can?t we simply persist both ISOs in the database? Without needing to use that ?determine? method.
   
   It seems that as long as we have both entries in the database (or new ones in the far far future ahead of us), your logic in ` CitrixResourceBase.java ` would take care of the rest. I would recommend one thing though. You have the strings "guest-tools" and "xs-tools" in two different classes (at least the ones I am seeing in this PR). What about extracting them to an enum?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services