You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2008/01/25 13:05:34 UTC
[jira] Created: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Move Jackrabbit Query Parser from core to spi-commons
-----------------------------------------------------
Key: JCR-1347
URL: https://issues.apache.org/jira/browse/JCR-1347
Project: Jackrabbit
Issue Type: Task
Components: query
Reporter: Julian Reschke
Priority: Minor
The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
Proposal:
- move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
- switch over jackrabbit.core to use spi-commons for query
- optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke updated JCR-1347:
--------------------------------
Attachment: 1347.tar.gz
Proposed change: adds JSR-170 query parsers (e.g., just XPath and SQL) plus the QueryTree code in spi-commons.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Priority: Minor
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568258#action_12568258 ]
Jukka Zitting commented on JCR-1347:
------------------------------------
I'd prefer to remove the SessionImpl dependencies.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1347:
-----------------------------------
Assignee: Julian Reschke
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger resolved JCR-1347.
-----------------------------------
Resolution: Fixed
Removed now obsolete packages from jackrabbit-core. Modify sources to use classes in jackrabbit-spi-commons.
svn revision: 629125
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571532#action_12571532 ]
Marcel Reutegger commented on JCR-1347:
---------------------------------------
Can you be a bit more specific? I've looked through the package names again, and they seem to be OK.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571104#action_12571104 ]
Marcel Reutegger commented on JCR-1347:
---------------------------------------
Forgot to adapt some of the package names.
Fixed in revision: 629877 and 629878
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571400#action_12571400 ]
Julian Reschke commented on JCR-1347:
-------------------------------------
There are some more problems with package names being broken because of the package move.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571554#action_12571554 ]
Julian Reschke commented on JCR-1347:
-------------------------------------
Ah, I missed to say "in the javadoc".
I fixed some in revision 630195. There maybe some left in sql2/qom. You probably need to run javadoc and grep for "core.query" in the error messages.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1347:
-----------------------------------
Assignee: (was: Julian Reschke)
Left to do: move over QOM and JSR283 parts; Marcel, do you want to do those?
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570228#action_12570228 ]
Marcel Reutegger commented on JCR-1347:
---------------------------------------
> Marcel, do you want to do those?
I will take care of it.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1347:
-----------------------------------
Assignee: (was: Julian Reschke)
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1347:
-------------------------------
Component/s: jackrabbit-spi-commons
jackrabbit-core
Fix Version/s: 1.5
Issue Type: Improvement (was: Task)
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569929#action_12569929 ]
Julian Reschke commented on JCR-1347:
-------------------------------------
Moved XPATH and SQL parsers and Query Tree Builder into spi-commons (see revisions 628742, 628755, 628779, 628787, 628790)
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568481#action_12568481 ]
Marcel Reutegger commented on JCR-1347:
---------------------------------------
Me too, see JCR-1378.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570265#action_12570265 ]
Marcel Reutegger commented on JCR-1347:
---------------------------------------
Copied jsr283.qom, qom and sql2 to jackrabbit-spi-commons.
svn revision: 629123
Adapted packages in revision: 629124
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568622#action_12568622 ]
Julian Reschke commented on JCR-1347:
-------------------------------------
Marcel, thanks for the fixes, but qom/jsr283 still seem to have dependencies.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568240#action_12568240 ]
Julian Reschke commented on JCR-1347:
-------------------------------------
I just tried this, and some of the code used by qom has dependencies on SessionImpl (which is not the case for xpath/sql).
So either we get rid of these dependencies first, or we need to restrict the move to those parts (JSR170) that actually can be moved.
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Task
> Components: query
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (JCR-1347) Move Jackrabbit Query Parser from core
to spi-commons
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julian Reschke reassigned JCR-1347:
-----------------------------------
Assignee: Julian Reschke
> Move Jackrabbit Query Parser from core to spi-commons
> -----------------------------------------------------
>
> Key: JCR-1347
> URL: https://issues.apache.org/jira/browse/JCR-1347
> Project: Jackrabbit
> Issue Type: Improvement
> Components: jackrabbit-core, jackrabbit-spi-commons, query
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Fix For: 1.5
>
> Attachments: 1347.tar.gz
>
>
> The query parser can be used outside jackrabbit-core, for instances in other repository implementations based on JCR2SPI.
> Proposal:
> - move source and build infrastructure from o.a.j.core.query to o.a.j.spi.commons.query
> - switch over jackrabbit.core to use spi-commons for query
> - optimally, add specific test cases for the query tree generation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.