[jira] [Commented] (ARROW-2236) [JS] Add more complete set of predicates

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382417#comment-16382417 ] 

ASF GitHub Bot commented on ARROW-2236:
---------------------------------------

TheNeuralBit commented on a change in pull request #1683: ARROW-2236: [JS] Add more complete set of predicates
URL: https://github.com/apache/arrow/pull/1683#discussion_r171646498
 
 

 ##########
 File path: js/test/unit/vector-tests.ts
 ##########
 @@ -18,7 +18,7 @@
 import { TextEncoder } from 'text-encoding-utf-8';
 import Arrow from '../Arrow';
 import { type, TypedArray, TypedArrayConstructor, Vector } from '../../src/Arrow';
-import { packBools } from '../../src/util/bit'
 
 Review comment:
   Yeah good call. My syntax checker, [tsuquyomi](https://github.com/Quramy/tsuquyomi), complains about the `const { type, Vector } = Arrow;` approach so I shied away from it, but the tests run just fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [JS] Add more complete set of predicates
> ----------------------------------------
>
>                 Key: ARROW-2236
>                 URL: https://issues.apache.org/jira/browse/ARROW-2236
>             Project: Apache Arrow
>          Issue Type: Task
>          Components: JavaScript
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>              Labels: pull-request-available
>
> Right now {{arrow.predicate}} only supports ==, >=, <=, &&, and ||
> We should also support !=, <, > at the very least



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)