You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2018/11/15 14:21:12 UTC

[jclouds/jclouds-site] Fix events and CI links (#222)

* Removed banned from the top of the site.
* Update the link to our new CI builds.
* Replace the stale link to the meetups page with a link to the upcoming Apache events as per http://events.apache.org/README.txt
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-site/pull/222

-- Commit Summary --

  * Fix events and CI links

-- File Changes --

    M _includes/navbar.html (6)
    M _layouts/home.html (2)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/222.patch
https://github.com/jclouds/jclouds-site/pull/222.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.



>              {% comment %}
+            {% include supportapache.html %}

No particular issue with hiding this, just curious about the reasoning? Is it because we're now listing Apache events in the "community" menu?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#pullrequestreview-175455640

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
Addressed comments, merged and published.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439219409

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Andrea Turli <no...@github.com>.
lgtm

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439082717

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Andrew Phillips <no...@github.com>.
Screenshot:

![image](https://user-images.githubusercontent.com/223702/48568601-c3758a00-e8cd-11e8-80c6-8a2585787965.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439112336

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Andrew Phillips <no...@github.com>.
> Addressed comments, merged and published.

![image](https://user-images.githubusercontent.com/223702/48588939-27687480-e907-11e8-8d99-12463a7cb19d.png)

Thanks, Ignasi!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439232098

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
Reopened #222.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#event-1968827727

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Andrew Phillips <no...@github.com>.
demobox commented on this pull request.



>                          <li><a href="https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute">How To Contribute Code</a></li>
                         <li><a href="https://cwiki.apache.org/confluence/display/JCLOUDS/How+to+Contribute+Documentation">How To Contribute Documentation</a></li>
+                        <li class="divider"></li>
+                        <li class="dropdown-header">Apache Events</li>
+                        <li><a href="https://www.apache.org/events/current-event.html"><img src="https://www.apache.org/events/current-event-234x60.png"/></a></li>

Would this perhaps be better placed in the `About Apache` menu? It doesn't really seem obviously related to the **jclouds** community as such?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#pullrequestreview-175456689

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by jclouds-commentator <no...@github.com>.
  Go to http://f4f21b6219618c1da02f-cce767494edd5ad1ac4ea844e71732c9.r85.cf5.rackcdn.com/ to review your changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439068830

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by jclouds-commentator <no...@github.com>.
  Go to http://bbcebc176f13530db745-416f4fbedb1d1c0842547ef272d03c8c.r84.cf5.rackcdn.com/ to review your changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#issuecomment-439222673

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
Closed #222.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#event-1969963994

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
nacx commented on this pull request.



>              {% comment %}
+            {% include supportapache.html %}

Yep, and we also have a link in the footer. There is no need for such a big disclaimer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#discussion_r234032741

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
@nacx pushed 1 commit.

6b42e9f  Move events to Apache menu


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222/files/c15171e679300a18082832be8979e905f7f6f575..6b42e9fd5c0ca13674d0afe4153007e7d43de69e

Re: [jclouds/jclouds-site] Fix events and CI links (#222)

Posted by Ignasi Barrera <no...@github.com>.
Closed #222.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/222#event-1968827572