Re: [PR] Fix Save Value to File for large debugger strings (#9452) [netbeans]

["matthiasblaesing (via GitHub)" <gi...@apache.org>]

matthiasblaesing commented on PR #9534:
URL: https://github.com/apache/netbeans/pull/9534#issuecomment-5798319576

   @kamilkrzywanski sorry for the late reply. I looked into this and while the changes improve the situation, it still felt off to me. The core problem for me is: Using string prefixes as keys for the full string. This is prone to collisions.
   
   I stepped back and considered the situation from a different perspective: for short string we don't need special handling as the value itself can be fetched and we are done. Caching the strings can help performance though. Special casing is only needed for the long strings and for these the approach suggested by #9635 is to return a special object `StringInfo` that holds the shortened string and all the data that is required to fetch the full string.
   
   Would you mind having a look at #9635 and test that approach? The nightly build is available from: https://github.com/apache/netbeans/suites/96877052987/artifacts/10718565851 (or via the checks page of the PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists