You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2023/11/28 07:21:22 UTC
[PR] arm/clang: replace deprecated parameter [nuttx]
anchao opened a new pull request, #11282:
URL: https://github.com/apache/nuttx/pull/11282
## Summary
arm/clang: replace deprecated parameter
In LLVM Clang 17.0.1, the `--config` parameter has been deprecated and replaced by the `-target` parameter
## Impact
N/A
## Testing
llvm clang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#discussion_r1409014840
##########
arch/arm/Kconfig:
##########
@@ -40,6 +40,7 @@ config ARM_TOOLCHAIN_GNU_OABI
config ARM_TOOLCHAIN_CLANG
bool "LLVM Clang toolchain"
+ depends on !LIBM_TOOLCHAIN && !LIBM_NONE
Review Comment:
but not all project use libm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "masayuki2009 (via GitHub)" <gi...@apache.org>.
masayuki2009 commented on PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#issuecomment-1831204646
>In LLVM Clang 17.0.1, the --config parameter has been deprecated and replaced by the -target parameter
clang 17.0.1 was introduced in https://github.com/apache/nuttx/pull/11270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#issuecomment-1829468595
Depends on: https://github.com/apache/nuttx-apps/pull/2214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#issuecomment-1831064535
> @anchao seems there is also an issue in the stm32h7 ethernet driver:
Done, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#issuecomment-1830607499
@anchao seems there is also an issue in the stm32h7 ethernet driver:
```
Error: chip/stm32_ethernet.c:2014:7: error: variable 'i' set but not used [-Werror,-Wunused-but-set-variable]
2014 | int i;
| ^
1 error generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#discussion_r1407989370
##########
boards/arm/stm32/viewtool-stm32f107/configs/tcpblaster/defconfig:
##########
@@ -24,6 +24,7 @@ CONFIG_INTELHEX_BINARY=y
CONFIG_IOB_NBUFFERS=50
CONFIG_IOB_NCHAINS=12
CONFIG_LIBC_HOSTNAME="Viewtool-STM32F107"
+CONFIG_LIBM=y
Review Comment:
Yes, This PR is to resolve the break of ci, since clang-17 does not provide the implementation of libm, so in order to completely solve similar issues, it is necessary to enable the implementation of libm in some boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #11282:
URL: https://github.com/apache/nuttx/pull/11282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on code in PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#discussion_r1409016122
##########
arch/arm/Kconfig:
##########
@@ -40,6 +40,7 @@ config ARM_TOOLCHAIN_GNU_OABI
config ARM_TOOLCHAIN_CLANG
bool "LLVM Clang toolchain"
+ depends on !LIBM_TOOLCHAIN && !LIBM_NONE
Review Comment:
Done, let me remove LIBM_NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arm/clang: replace deprecated parameter [nuttx]
Posted by "hartmannathan (via GitHub)" <gi...@apache.org>.
hartmannathan commented on code in PR #11282:
URL: https://github.com/apache/nuttx/pull/11282#discussion_r1407945193
##########
boards/arm/stm32/viewtool-stm32f107/configs/tcpblaster/defconfig:
##########
@@ -24,6 +24,7 @@ CONFIG_INTELHEX_BINARY=y
CONFIG_IOB_NBUFFERS=50
CONFIG_IOB_NCHAINS=12
CONFIG_LIBC_HOSTNAME="Viewtool-STM32F107"
+CONFIG_LIBM=y
Review Comment:
Are the changes in `boards/arm/stm32/viewtool-stm32f107/configs/tcpblaster/defconfig` meant to be included in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org