You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <pe...@famlundblad.se> on 2005/04/14 06:45:57 UTC
r14149
Hi,
I wanted to add r14149 to r14041 in the 1.2 STATUS file (and vote for
them), since that makes the change actually smaller. Looking at r14149, I
realize that it uses dav_xml_get_cdata to get its paths, but with the last
argument (strip_whitespace) set to 1. This breaks for paths containing
spaces at the ends, or do I miss something?
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: r14149
Posted by "C. Michael Pilato" <cm...@collab.net>.
"C. Michael Pilato" <cm...@collab.net> writes:
> Yes, once I commit those up, I'll nominate them. Turns out this
> problem is more widespread in mod_dav_svn than just the update
> report.
Done. See STATUS.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: r14149
Posted by "C. Michael Pilato" <cm...@collab.net>.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> On Thu, 14 Apr 2005, C. Michael Pilato wrote:
>
> > "Peter N. Lundblad" <pe...@famlundblad.se> writes:
> >
> > > I wanted to add r14149 to r14041 in the 1.2 STATUS file (and vote for
> > > them), since that makes the change actually smaller. Looking at r14149, I
> > > realize that it uses dav_xml_get_cdata to get its paths, but with the last
> > > argument (strip_whitespace) set to 1. This breaks for paths containing
> > > spaces at the ends, or do I miss something?
> >
> > No, you missed nothing. I did a macro-based replacement of those
> > lines of code, and even made a note to myself to go back and flip the
> > strip_whitespace bit to 0 for src-path, dst-path, and update-target,
> > but completely forgot to actually *do* that.
> >
> > Will do now.
> >
> Nice! Do you nominate those then?
Yes, once I commit those up, I'll nominate them. Turns out this
problem is more widespread in mod_dav_svn than just the update report.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: r14149
Posted by "Peter N. Lundblad" <pe...@famlundblad.se>.
On Thu, 14 Apr 2005, C. Michael Pilato wrote:
> "Peter N. Lundblad" <pe...@famlundblad.se> writes:
>
> > I wanted to add r14149 to r14041 in the 1.2 STATUS file (and vote for
> > them), since that makes the change actually smaller. Looking at r14149, I
> > realize that it uses dav_xml_get_cdata to get its paths, but with the last
> > argument (strip_whitespace) set to 1. This breaks for paths containing
> > spaces at the ends, or do I miss something?
>
> No, you missed nothing. I did a macro-based replacement of those
> lines of code, and even made a note to myself to go back and flip the
> strip_whitespace bit to 0 for src-path, dst-path, and update-target,
> but completely forgot to actually *do* that.
>
> Will do now.
>
Nice! Do you nominate those then?
Regards,
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: r14149
Posted by "C. Michael Pilato" <cm...@collab.net>.
"Peter N. Lundblad" <pe...@famlundblad.se> writes:
> I wanted to add r14149 to r14041 in the 1.2 STATUS file (and vote for
> them), since that makes the change actually smaller. Looking at r14149, I
> realize that it uses dav_xml_get_cdata to get its paths, but with the last
> argument (strip_whitespace) set to 1. This breaks for paths containing
> spaces at the ends, or do I miss something?
No, you missed nothing. I did a macro-based replacement of those
lines of code, and even made a note to myself to go back and flip the
strip_whitespace bit to 0 for src-path, dst-path, and update-target,
but completely forgot to actually *do* that.
Will do now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org