You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/17 09:35:05 UTC
[GitHub] [streampipes] tenthe opened a new issue, #1113: Add buttons to start and stop all adapters
tenthe opened a new issue, #1113:
URL: https://github.com/apache/streampipes/issues/1113
### Body
# Description
A user should have the option to start / stop all adapters together.
You can have a look at the feature in the pipeline overview (`start all pipelines` / `stop all pipelines`).
The same functionality should be available for the adapters in the connect view.
# Mentoring
As this ticket is marked as good first issue: one of @dominikriemer or @tenthe are happy to provide help for getting started, just tag (one of) them if you want to start working on this issue and need some help.
If you are familiar with Angular, this is a good issue to get started with UI development in StreamPipes.
### StreamPipes Committer
I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1467553419
Hi @bossenti, Iād like to work on this issue. Could you assign this task to me? Any resources related to the issue would help a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1474103752
Hm, I'm not really an expert with respect to our UI
Maybe @tenthe or @smlabt can help you here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1480106986
Hello @tenthe, I went over #1290 and #1289... I understand the need to remove set adapters. But even when I'm trying to start/stop specific `MachineDataSimulator` adaptors which are stream adapters, I am getting the same
```
Property 'running' does not exist on type 'AdapterDescriptionUnion'.
Property 'running' does not exist on type 'GenericAdapterSetDescription'.ts(2339)
```
error. Any idea why this is happening? For now, I'm passing the list of all adapters to the `start all adapters` / `stop all adapters` functions and it is working fine. If I was able to access the `running` field, I could only show the adapters to be started or stopped instead of displaying the entire list of adapters (present in My Adapters) in the dialog box...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe closed issue #1113: Add buttons to start and stop all adapters
URL: https://github.com/apache/streampipes/issues/1113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "tenthe (via GitHub)" <gi...@apache.org>.
tenthe commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1479836833
Hello @dominikriemer, hello @purplesmurf45,
the reason was that set adapters were started as soon as the pipeline was invoked. So users could not manually start or stop a set adapter.
@purplesmurf45 for this issue you can ignore the `...SetDescription` as we will remove set adapters soon.
Hope this helps. Please let us know if there are any other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "bossenti (via GitHub)" <gi...@apache.org>.
bossenti commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1467766273
Sure š
The pipeline overview that is mentioned in the description as reference can be found here: https://github.com/apache/streampipes/blob/dev/ui/src/app/pipelines/pipelines.component.html & https://github.com/apache/streampipes/blob/dev/ui/src/app/pipelines/pipelines.component.ts
The corresponding adapter view where this functionality should be added is this one: https://github.com/apache/streampipes/tree/dev/ui/src/app/connect/components/existing-adapters
Here is a documentation on how to develop the UI: https://cwiki.apache.org/confluence/display/STREAMPIPES/UI
Do you need anything more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1480287254
Fixed the above-specified error by filtering the stream adapters from all adapters and accessing the `running` flag for these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1472192573
Hey @tenthe @bossenti, the `start all pipelines` / `stop all pipelines` both open a dialog box to show the status of the processes. Should this dialog box also be replicated for `start all adapters` / `stop all adapters` functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1475674886
@tenthe @smlabt could you help me with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1468798966
This was helpful! I have started working on it. I will update you if I face any issues š
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "dominikriemer (via GitHub)" <gi...@apache.org>.
dominikriemer commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1478165767
@purplesmurf45 thanks for the good explanation!
@tenthe
I had a look at the adapter data models and it seems the `running` attribute is only avaiable for `AdapterStreamDescription` classes. Is there a reason why we do not have the `running` field at the top-level class `AdapterDescription`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add buttons to start and stop all adapters (streampipes)
Posted by "purplesmurf45 (via GitHub)" <gi...@apache.org>.
purplesmurf45 commented on issue #1113:
URL: https://github.com/apache/streampipes/issues/1113#issuecomment-1473233070
@bossenti @dominikriemer
I am trying to access the running flag of adapters but I am facing this error -
```
Property 'running' does not exist on type 'AdapterDescriptionUnion'.
Property 'running' does not exist on type 'GenericAdapterSetDescription'.ts(2339)
```
On further inspection, I noticed that this value is being accessed by a different function and that function is working fine. When I printed out the attributes of AdapterDescriptionUnion, I could see that the running attribute does exist and has a value associated with it. Can someone help me understand why this is happening? And is there any workaround for getting the running state of adapters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org