You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2017/01/07 22:56:46 UTC
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/350
STREAMS-255: remove incubator-streams dependency on incubator-streams-master
also reorganizes website hierarchy some-what
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #350
----
commit b3604a6ed808dc04490f098c6b69c31369a95ca3
Author: Steve Blackmon <sb...@apache.org>
Date: 2017-01-07T22:55:38Z
STREAMS-255: remove incubator-streams dependency on incubator-streams-master
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/350#discussion_r95892279
--- Diff: pom.xml ---
@@ -158,10 +273,105 @@
</snapshotRepository>
<site>
<id>site.streams.project</id>
- <url>scm:svn:https://svn.apache.org/repos/asf/incubator/streams/site/trunk/content/site/${project.version}/streams-project</url>
+ <url>scm:svn:https://svn.apache.org/repos/asf/incubator/streams/site/trunk/content/site/${project.version}/${project.artifactId}</url>
</site>
</distributionManagement>
+ <properties>
+
+ <!-- Build Properties -->
+ <java.version>1.8</java.version>
+ <maven.version>3.3.9</maven.version>
+ <scala.suffix>2.10</scala.suffix>
+ <scala.version>2.10.6</scala.version>
+ <maven.javadoc.failOnError>false</maven.javadoc.failOnError>
+ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+ <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
+ <streams.version>0.4-incubating-SNAPSHOT</streams.version>
--- End diff --
Yeah so 0.4-incubating-SNAPSHOT isn't right. Should either at least be 0.4.1-incubating-SNAPSHOT or 0.5-incubating-SNAPSHOT which is what the current incubator-streams project repo pom.xml is at.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #350: STREAMS-255: remove incubator-streams dependen...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-streams/pull/350
+1 - ran a complete build on incubator-streams and incubator-streams-examples and all unit tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/350#discussion_r95891542
--- Diff: pom.xml ---
@@ -82,9 +71,135 @@
<post>dev@streams.incubator.apache.org</post>
<subscribe>dev-subscribe@streams.incubator.apache.org</subscribe>
<unsubscribe>dev-unsubscribe@streams.incubator.apache.org</unsubscribe>
+ <archive>http://mail-archives.apache.org/mod_mbox/incubator-streams-dev/</archive>
+ </mailingList>
+ <mailingList>
+ <name>Commits Mailing List</name>
+ <post>commits@streams.incubator.apache.org</post>
+ <subscribe>commits-subscribe@streams.incubator.apache.org</subscribe>
+ <unsubscribe>commits-unsubscribe@streams.incubator.apache.org</unsubscribe>
+ <archive>http://mail-archives.apache.org/mod_mbox/incubator-streams-commits/</archive>
--- End diff --
Any thought on updating this to the lists.apache.org one? Or is that still unofficial?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/350#discussion_r96124956
--- Diff: src/site/site.xml ---
@@ -40,19 +76,55 @@
<item name="Architecture" href="architecture.html" />
<item name="Concepts" href="concepts.html" />
<item name="Downloads" href="downloads.html" />
+ <item name="Examples" href="http://streams.incubator.apache.org/site/latest/streams-examples/" />
<item name="Frequently Asked Questions" href="faq.html" />
+ <item name="Modules" href="modules.html" />
</menu>
- <menu name="Projects" inherit="top">
- <item name="streams-master" />
- <item name="streams-project" href="http://streams.incubator.apache.org/site/latest/streams-project" />
- <item name="streams-examples" href="http://streams.incubator.apache.org/site/latest/streams-examples/" />
+ <menu name="Users">
+ <item name="Install Java" href="install/java.html"/>
+ <item name="Install Docker" href="install/docker.html"/>
+ <item name="Install SBT" href="install/sbt.html"/>
+ <item name="Credentials">
+ <item name="Twitter" href="credentials/twitter.html" />
+ </item>
+ <item name="Services">
+ <item name="Cassandra" href="services/cassandra.html" />
+ <item name="Elasticsearch" href="services/elasticsearch.html" />
+ <item name="HBase" href="services/hbase.html" />
--- End diff --
Ditto for HBase.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/350#discussion_r96124950
--- Diff: src/site/site.xml ---
@@ -40,19 +76,55 @@
<item name="Architecture" href="architecture.html" />
<item name="Concepts" href="concepts.html" />
<item name="Downloads" href="downloads.html" />
+ <item name="Examples" href="http://streams.incubator.apache.org/site/latest/streams-examples/" />
<item name="Frequently Asked Questions" href="faq.html" />
+ <item name="Modules" href="modules.html" />
</menu>
- <menu name="Projects" inherit="top">
- <item name="streams-master" />
- <item name="streams-project" href="http://streams.incubator.apache.org/site/latest/streams-project" />
- <item name="streams-examples" href="http://streams.incubator.apache.org/site/latest/streams-examples/" />
+ <menu name="Users">
+ <item name="Install Java" href="install/java.html"/>
+ <item name="Install Docker" href="install/docker.html"/>
+ <item name="Install SBT" href="install/sbt.html"/>
+ <item name="Credentials">
+ <item name="Twitter" href="credentials/twitter.html" />
+ </item>
+ <item name="Services">
+ <item name="Cassandra" href="services/cassandra.html" />
--- End diff --
The C* service page doesn't seem to be getting generated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #350: STREAMS-255: remove incubator-streams d...
Posted by jfrazee <gi...@git.apache.org>.
Github user jfrazee commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/350#discussion_r95895146
--- Diff: pom.xml ---
@@ -235,7 +888,7 @@
<id>validate</id>
<phase>validate</phase>
<configuration>
- <configLocation>http://streams.incubator.apache.org/site/${project.version}/streams-master/streams-java-checkstyle.xml</configLocation>
+ <configLocation>http://streams.incubator.apache.org/site/latest/streams-master/streams-java-checkstyle.xml</configLocation>
--- End diff --
Two problems with this I think. First, it references streams-master. Is the site still being published to streams-master (I'll probably answer that to myself in a minute). Second, suppose we evolve the check style forward, old existing Apache releases could be invalid against it. That seems wrong as if it checks out ok at time of release, it always should (or at least until we hit a 1.x or release that makes the old stuff out of maintenance).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---