You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Ray <ra...@cisco.com> on 2018/05/28 05:40:33 UTC

Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Valentin Kulichenko and Nikolay Izhikov can you please take a look at PR and
provide comments? Other reviewers are welcome as well.

https://github.com/apache/ignite/pull/4033

I modified Ignite Spark module to fit Spark 2.3 APIs and removed spark-2.10
module because Spark 2.3 stooped support for scala 2.10.
https://issues.apache.org/jira/browse/SPARK-19810

Also, please find the dev list discussion thread here.
http://apache-ignite-developers.2346864.n4.nabble.com/Discussion-Upgrade-Ignite-Spark-Module-s-Spark-version-to-2-3-0-td30762.html

Ray




--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Posted by Ray <ra...@cisco.com>.

Before spark 2.3, spark is compiled using scala 2.11 and 2.10 separately.
Spark-2.10 module in Ignite exists to accommodate this, it's not used
anywhere else in project.
Now spark 2.3 decided to remove support for scala 2.10, so we can safely
remove spark-2.10 module in Ignite.

It won't affect visor-console-2.10 and scala-2.10 modules because these two
modules are Ignite internal modules to support legacy users using scala
2.10.



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Posted by Petr Ivanov <mr...@gmail.com>.

Ray, could you share details of your investigation regarding spark-2.10 module removal?

Is it not used anywhere that it can be safely removed?
And what about visor-console-2.10 and scala-2.10 modules?

> On 30 May 2018, at 08:41, Ray <ra...@cisco.com> wrote:
> 
> Hi Dmitriy,
> 
> Thanks for the reply.
> 
> I have resolved conflicts in PR and changed the ticket status to path
> available.
> Please review and leave comments.
> 
> Thanks
> 
> 
> 
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Posted by Ray <ra...@cisco.com>.

Hi Dmitriy,

Thanks for the reply.

I have resolved conflicts in PR and changed the ticket status to path
available.
Please review and leave comments.

Thanks



--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Ray,

Could you also please resolve conflicts in PR?

Conflicting files
modules/spark-2.10/pom.xml

вт, 29 мая 2018 г. в 18:19, Dmitry Pavlov <dp...@gmail.com>:

> Hi Ray,
>
> Status of this ticket is In Progress, so it is not displayed in filters.
>
> Could you please set status to Patch Available if PR is ready for review?
>
> Sincerely,
> Dmitriy Pavlov
>
> пн, 28 мая 2018 г. в 8:40, Ray <ra...@cisco.com>:
>
>> Valentin Kulichenko and Nikolay Izhikov can you please take a look at PR
>> and
>> provide comments? Other reviewers are welcome as well.
>>
>> https://github.com/apache/ignite/pull/4033
>>
>> I modified Ignite Spark module to fit Spark 2.3 APIs and removed
>> spark-2.10
>> module because Spark 2.3 stooped support for scala 2.10.
>> https://issues.apache.org/jira/browse/SPARK-19810
>>
>> Also, please find the dev list discussion thread here.
>>
>> http://apache-ignite-developers.2346864.n4.nabble.com/Discussion-Upgrade-Ignite-Spark-Module-s-Spark-version-to-2-3-0-td30762.html
>>
>> Ray
>>
>>
>>
>>
>> --
>> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>>
>

Re: Review request for IGNITE-8534 Upgrade Ignite Spark Module's Spark version to 2.3.

Posted by Dmitry Pavlov <dp...@gmail.com>.

Hi Ray,

Status of this ticket is In Progress, so it is not displayed in filters.

Could you please set status to Patch Available if PR is ready for review?

Sincerely,
Dmitriy Pavlov

пн, 28 мая 2018 г. в 8:40, Ray <ra...@cisco.com>:

> Valentin Kulichenko and Nikolay Izhikov can you please take a look at PR
> and
> provide comments? Other reviewers are welcome as well.
>
> https://github.com/apache/ignite/pull/4033
>
> I modified Ignite Spark module to fit Spark 2.3 APIs and removed spark-2.10
> module because Spark 2.3 stooped support for scala 2.10.
> https://issues.apache.org/jira/browse/SPARK-19810
>
> Also, please find the dev list discussion thread here.
>
> http://apache-ignite-developers.2346864.n4.nabble.com/Discussion-Upgrade-Ignite-Spark-Module-s-Spark-version-to-2-3-0-td30762.html
>
> Ray
>
>
>
>
> --
> Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
>