[GitHub] [iceberg] chenjunjiedada commented on a diff in pull request #5376: Core: Add readable metrics columns to files metadata tables

[GitBox <gi...@apache.org>]

chenjunjiedada commented on code in PR #5376:
URL: https://github.com/apache/iceberg/pull/5376#discussion_r1011640444


##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -142,9 +142,21 @@ public static Schema selectNot(Schema schema, Set<Integer> fieldIds) {
   }
 
   public static Schema join(Schema left, Schema right) {
-    List<Types.NestedField> joinedColumns = Lists.newArrayList();
-    joinedColumns.addAll(left.columns());

Review Comment:
   nit: This changes the original behavior, why not add a new function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org