You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Alan Conway <ac...@redhat.com> on 2012/07/10 21:10:12 UTC
Review Request: HA primary times out expected backups.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5890/
-----------------------------------------------------------
Review request for qpid.
Description
-------
After a failure, the newly-promoted primary broker guards messages for each of the backups that were connected at the time of the failure. It waits for them to reconnect to the new primary before becoming active.
This patch introduces a time-out so that if an expected backup fails to fail-over within the time limit, the primary will cancel the guards for that backup and carry on.
Diffs
-----
/trunk/qpid/cpp/src/qpid/ha/HaPlugin.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/Primary.h 1359673
/trunk/qpid/cpp/src/qpid/ha/Primary.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/RemoteBackup.h 1359673
/trunk/qpid/cpp/src/qpid/ha/RemoteBackup.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/Settings.h 1359673
/trunk/qpid/cpp/src/tests/ha_tests.py 1359673
Diff: https://reviews.apache.org/r/5890/diff/
Testing
-------
Thanks,
Alan Conway
Re: Review Request: HA primary times out expected backups.
Posted by Gordon Sim <gs...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5890/#review9062
-----------------------------------------------------------
Ship it!
Not terribly familar with all the logic here yet, but the changes all seem reasonable to me.
- Gordon Sim
On July 10, 2012, 7:10 p.m., Alan Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5890/
> -----------------------------------------------------------
>
> (Updated July 10, 2012, 7:10 p.m.)
>
>
> Review request for qpid and Gordon Sim.
>
>
> Description
> -------
>
> After a failure, the newly-promoted primary broker guards messages for each of the backups that were connected at the time of the failure. It waits for them to reconnect to the new primary before becoming active.
>
> This patch introduces a time-out so that if an expected backup fails to fail-over within the time limit, the primary will cancel the guards for that backup and carry on.
>
>
> Diffs
> -----
>
> /trunk/qpid/cpp/src/qpid/ha/HaPlugin.cpp 1359673
> /trunk/qpid/cpp/src/qpid/ha/Primary.h 1359673
> /trunk/qpid/cpp/src/qpid/ha/Primary.cpp 1359673
> /trunk/qpid/cpp/src/qpid/ha/RemoteBackup.h 1359673
> /trunk/qpid/cpp/src/qpid/ha/RemoteBackup.cpp 1359673
> /trunk/qpid/cpp/src/qpid/ha/Settings.h 1359673
> /trunk/qpid/cpp/src/tests/ha_tests.py 1359673
>
> Diff: https://reviews.apache.org/r/5890/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan Conway
>
>
Re: Review Request: HA primary times out expected backups.
Posted by Alan Conway <ac...@redhat.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5890/
-----------------------------------------------------------
(Updated July 10, 2012, 7:10 p.m.)
Review request for qpid and Gordon Sim.
Description
-------
After a failure, the newly-promoted primary broker guards messages for each of the backups that were connected at the time of the failure. It waits for them to reconnect to the new primary before becoming active.
This patch introduces a time-out so that if an expected backup fails to fail-over within the time limit, the primary will cancel the guards for that backup and carry on.
Diffs
-----
/trunk/qpid/cpp/src/qpid/ha/HaPlugin.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/Primary.h 1359673
/trunk/qpid/cpp/src/qpid/ha/Primary.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/RemoteBackup.h 1359673
/trunk/qpid/cpp/src/qpid/ha/RemoteBackup.cpp 1359673
/trunk/qpid/cpp/src/qpid/ha/Settings.h 1359673
/trunk/qpid/cpp/src/tests/ha_tests.py 1359673
Diff: https://reviews.apache.org/r/5890/diff/
Testing
-------
Thanks,
Alan Conway