You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/01/14 23:03:14 UTC

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22342


Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................

[tserver] disable KUDU-3486 behavior by default

This is a quick-and-dirty fix to mitigate KUDU-3638.

This patch isn't focusing on properly addressing the issues that
KUDU-3486 has introduced apart from fixing the obvious bug of missing
updates of the Heartbeater::Thread::last_tombstoned_report_time_ field.
Also, with this patch, the functionality introduced with KUDU-3486
is now disabled by default.  To re-enable it back, customize the setting
for the --tserver_send_tombstoned_tablets_report_inteval_secs flag,
if needed.

Properly implementing the functionality that KUDU-3486 attempted to add
would be a much more involved patch because there are several items
to address from both the design and implementation standpoints.

Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Reviewed-on: http://gerrit.cloudera.org:8080/22341
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 0ddaac556f7bc7aeb47db740300921d10eabd856)
---
M src/kudu/tserver/heartbeater.cc
1 file changed, 8 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/22342/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22342 )

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/924/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Comment-Date: Wed, 15 Jan 2025 01:36:11 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22342 )

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Comment-Date: Tue, 14 Jan 2025 23:52:16 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22342 )

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/924/


-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 14 Jan 2025 23:03:24 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22342 )

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................


Patch Set 1: Verified+1

unrelated test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Comment-Date: Wed, 15 Jan 2025 02:33:46 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [tserver] disable KUDU-3486 behavior by default

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22342 )

Change subject: [tserver] disable KUDU-3486 behavior by default
......................................................................

[tserver] disable KUDU-3486 behavior by default

This is a quick-and-dirty fix to mitigate KUDU-3638.

This patch isn't focusing on properly addressing the issues that
KUDU-3486 has introduced apart from fixing the obvious bug of missing
updates of the Heartbeater::Thread::last_tombstoned_report_time_ field.
Also, with this patch, the functionality introduced with KUDU-3486
is now disabled by default.  To re-enable it back, customize the setting
for the --tserver_send_tombstoned_tablets_report_inteval_secs flag,
if needed.

Properly implementing the functionality that KUDU-3486 attempted to add
would be a much more involved patch because there are several items
to address from both the design and implementation standpoints.

Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Reviewed-on: http://gerrit.cloudera.org:8080/22341
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 0ddaac556f7bc7aeb47db740300921d10eabd856)
Reviewed-on: http://gerrit.cloudera.org:8080/22342
---
M src/kudu/tserver/heartbeater.cc
1 file changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22342
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e32aafab99c74f0ead3ba65aea58ce91d40297c
Gerrit-Change-Number: 22342
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>