You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/07 20:20:42 UTC
[GitHub] [zookeeper] nkalmar opened a new pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
nkalmar opened a new pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar closed pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
nkalmar closed pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451#issuecomment-688498585
We've seen demand for code coverage, and some apache projects are already using jacoco.
I found an old jira to integrate jacoco with ant.
I know this doesn't really tell us how good are testing is (specially that for many tests we spin up a whole zk server), but there is a demand to see this in reports, so.. here it is.
I did several tests (all test, one test, jacoco on/off and see generated sources - should be only in zk-server), a good starting point:
'mvn clean install -Dtest=WatcherTest -DfailIfNoTests=false -Dcodecoverage'
By default code coverage is off, enable it by adding -Dcodecoverage to mvn args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451#issuecomment-697210354
@nkalmar Travis is not running tests, so it will be useless.
We have to add it to Jenkins builds.
It will also require to share the secret TOKEN on Jenkins, because in Travis is it simpler because there is an automatic integration .
Unfortunately the test suite it too big for Travis (or at least we have too many output pauses)
if we fix the Travis build, by running at least Java tests, we can go the way you are suggesting
cc @anmolnar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] hanm commented on pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
hanm commented on pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451#issuecomment-701870440
we already have clover for code coverage (in ant days) and seems maven build support clover too. do we plan to deprecate clover in favor of JaCoCo?
in any case, it's good to have more testing related addition for ZK as part of CI pipeline.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451#issuecomment-696934765
Hi @eolivelli , I tried to integrate coveralls according to the [readme](https://github.com/trautonen/coveralls-maven-plugin).
I enabled Apache/ZooKeeper on github in coveralls.io.
Now, if I understand this, I should just add
after_success:
- mvn clean cobertura:cobertura coveralls:report
to travis.yml? Is that it? (I already added the maven plugin dependency, it doesn't run in local as it needs the repokey)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] nkalmar commented on pull request #1451: ZOOKEEPER-2266: Integrate JaCoCo Coverage Library
Posted by GitBox <gi...@apache.org>.
nkalmar commented on pull request #1451:
URL: https://github.com/apache/zookeeper/pull/1451#issuecomment-696934765
Hi @eolivelli , I tried to integrate coveralls according to the [readme](https://github.com/trautonen/coveralls-maven-plugin).
I enabled Apache/ZooKeeper on github in coveralls.io.
Now, if I understand this, I should just add
after_success:
- mvn clean cobertura:cobertura coveralls:report
to travis.yml? Is that it? (I already added the maven plugin dependency, it doesn't run in local as it needs the repokey)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org