You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by huitseeker <gi...@git.apache.org> on 2015/10/21 19:48:36 UTC

[GitHub] spark pull request: [SPARK-8835] Provide pluggable Congestion Stra...

GitHub user huitseeker opened a pull request:

    https://github.com/apache/spark/pull/9200

    [SPARK-8835] Provide pluggable Congestion Strategies for Receiver-based Streams

    The new (destructive) strategies avoid leaving elements in the TCP buffer, leading to breakages at the sender level when this buffer finally drops them.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huitseeker/spark feature/CongestionStrategies

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9200
    
----
commit df1d1a6af6be0f0c9bf24c3b9496d220954afaf2
Author: François Garillot <fr...@garillot.net>
Date:   2015-10-20T14:18:38Z

    [SPARK-8835] Removes variable-less interpolation.

commit 013ac377eed81385b40af6753f5ba4a834c38144
Author: François Garillot <fr...@garillot.net>
Date:   2015-10-20T15:18:06Z

    [SPARK-8835] Make no-update of rate limiter with 0 explicit.

commit 6268c2cf89a4ce1cda0650b184e6d85826f2af7c
Author: François Garillot <fr...@garillot.net>
Date:   2015-10-21T13:56:53Z

    [SPARK-8835] Adds strategies for dealing with congestion on Receiver-based streams

commit 8cbadacb3b492ebbdd8283379fe99ce8534ad896
Author: François Garillot <fr...@garillot.net>
Date:   2015-10-21T15:12:42Z

    [SPARK-8835] Adds tests for congestion strategies
    Folds in the block generator throttling test from ReceiverSuite

commit 2e8e5deeacdca0bce3c24ea62c85811fef70a9b4
Author: François Garillot <fr...@garillot.net>
Date:   2015-10-21T15:15:36Z

    [SPARK-8835] TUrn off block generator throttling tests for long runtime
    
    THe previous commit (with tests) should pass PR validation though

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151799494
  
    **[Test build #44519 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44519/consoleFull)** for PR 9200 at commit [`bc06de2`](https://github.com/apache/spark/commit/bc06de24885c0c2b1304f9d3c9e349a7c06cc6e1).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:\n  * `class BernoulliSampler[T: ClassTag](fraction: Double,`\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151800083
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by tdas <gi...@git.apache.org>.

Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151784231
  
    I think this requires a good design doc for me to make sense of the overall idea, and discuss the design. Its hard to discuss the design in the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by huitseeker <gi...@git.apache.org>.

Github user huitseeker commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-150938419
  
    Pinging @srowen for an 'ok to test'.
    Also, if you're asking yourself why some tests are in "ignore" : the answer is in the commit messages.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151832704
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44520/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151788695
  
    **[Test build #44516 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44516/consoleFull)** for PR 9200 at commit [`2e8e5de`](https://github.com/apache/spark/commit/2e8e5deeacdca0bce3c24ea62c85811fef70a9b4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151798375
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151800060
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151799495
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151832701
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151799146
  
    **[Test build #44519 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44519/consoleFull)** for PR 9200 at commit [`bc06de2`](https://github.com/apache/spark/commit/bc06de24885c0c2b1304f9d3c9e349a7c06cc6e1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151789070
  
    **[Test build #44516 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44516/consoleFull)** for PR 9200 at commit [`2e8e5de`](https://github.com/apache/spark/commit/2e8e5deeacdca0bce3c24ea62c85811fef70a9b4).
     * This patch **fails Scala style tests**.
     * This patch merges cleanly.
     * This patch adds the following public classes _(experimental)_:\n  * `class BernoulliSampler[T: ClassTag](fraction: Double, rng: Random = RandomSampler.newDefaultRNG) extends RandomSampler[T, T] `\n


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151785444
  
     Merged build triggered.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-8835][Streaming] Provide pluggable Cong...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/9200#issuecomment-151785518
  
    Merged build started.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #9200: [SPARK-8835][Streaming] Provide pluggable Congesti...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/9200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org