You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/28 18:59:36 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #6175: libc: Remove the redundant seek in writev

xiaoxiang781216 opened a new pull request, #6175:
URL: https://github.com/apache/incubator-nuttx/pull/6175

   ## Summary
   since the file position isn't changed if write return fail
   
   ## Impact
   writev
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6175: libc: Remove the redundant seek in writev

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6175:
URL: https://github.com/apache/incubator-nuttx/pull/6175


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6175: libc: Remove the redundant seek in writev

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6175:
URL: https://github.com/apache/incubator-nuttx/pull/6175#issuecomment-1112806254

   > But the file position is changed after the first successful iteration in the `for` loop.
   
   two cases here:
   
   1. If fail at the iteration, the position isn't change
   2. If fail at other iteration, writev shouldn't return error since ntotal is always > 0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] onegray commented on pull request #6175: libc: Remove the redundant seek in writev

Posted by GitBox <gi...@apache.org>.
onegray commented on PR #6175:
URL: https://github.com/apache/incubator-nuttx/pull/6175#issuecomment-1112688917

   But the file position is changed after the first successful iteration in the `for` loop. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6175: libc: Remove the redundant seek in writev

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6175:
URL: https://github.com/apache/incubator-nuttx/pull/6175#issuecomment-1114151042

   ping @pkarashchenko 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org