You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hzyuemeng1 <gi...@git.apache.org> on 2016/10/21 10:00:36 UTC
[GitHub] flink pull request #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSou...
GitHub user hzyuemeng1 opened a pull request:
https://github.com/apache/flink/pull/2678
[FLINK-4879] [Kafka-Connector] class KafkaTableSource should be public just like KafkaTableSink
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hzyuemeng1/flink KafkaTableSource_should_public
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2678.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2678
----
commit 9d2d18c5e32e4e89d9482b6b6e70c4891f551109
Author: hzyuemeng1 <hz...@corp.netease.com>
Date: 2016-10-21T09:27:12Z
class KafkaTableSource should be public
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by hzyuemeng1 <gi...@git.apache.org>.
Github user hzyuemeng1 commented on the issue:
https://github.com/apache/flink/pull/2678
@wuchong can u help me to inform someone to merge this pr,thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSou...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2678
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2678
Thank you for opening a pull request.
@fhueske @twalthr @uce I think its okay to make the class public, in case users want to use a custom Kafka consumer, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by hzyuemeng1 <gi...@git.apache.org>.
Github user hzyuemeng1 commented on the issue:
https://github.com/apache/flink/pull/2678
@fhueske @rmetzger ,thanks all for review this pr,I am very interesting in Table SQL,can anyone merge this pr?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2678
+1 this looks fine to me, no problem with making it public.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/2678
+1 to merge this. I think it's fine to make `KafkaTableSource` public, just like `FlinkKafkaConsumerBase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2678
I think it's fine to make `KafkaTableSource` public.
However, I think users usually want to go for a version-specific `KafkaTableSource` like `Kafka090TableSource`. The version-specific sources are all declared `public`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2678: [FLINK-4879] [Kafka-Connector] class KafkaTableSource sho...
Posted by hzyuemeng1 <gi...@git.apache.org>.
Github user hzyuemeng1 commented on the issue:
https://github.com/apache/flink/pull/2678
thanks for ur review,i am very interesting about Table SQL,and want to make it better
2016-10-24
hzyuemeng1
\u53d1\u4ef6\u4eba\uff1aJark <no...@github.com>
\u53d1\u9001\u65f6\u95f4\uff1a2016-10-24 09:57
\u4e3b\u9898\uff1aRe: [apache/flink] [FLINK-4879] [Kafka-Connector] class KafkaTableSource should be public just like KafkaTableSink (#2678)
\u6536\u4ef6\u4eba\uff1a"apache/flink"<fl...@noreply.github.com>
\u6284\u9001\uff1a"hzyuemeng1"<hz...@noreply.github.com>
+1 to merge this. I think it's fine to make KafkaTableSource public, just like FlinkKafkaConsumerBase.
\u2014
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---