[GitHub] spark pull request #17673: [SPARK-20372] [ML] Word2Vec Continuous Bag of Wor...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17673#discussion_r114526827
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala ---
    @@ -102,6 +107,24 @@ private[feature] trait Word2VecBase extends Params
         "be divided into chunks up to the size (> 0)", ParamValidators.gt(0))
       setDefault(maxSentenceLength -> 1000)
     
    +  /**
    +   * Choose the technique to use for generating word embeddings
    +   * Default: true (Use Skip-Gram with Hierarchical softmax)
    +   * @group param
    +   */
    +  final val skipGram = new BooleanParam(this, "skipGram", "Use Skip-Gram model to generate word " +
    --- End diff --
    
    We could use `HasSolver` trait here 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org