You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2021/03/31 21:35:57 UTC

[Impala-ASF-CR] IMPALA-9910: [DOCS] update retry failed queries query option

Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 )

Change subject: IMPALA-9910: [DOCS] update retry failed queries query option
......................................................................


Patch Set 1:

(4 comments)

I have a few suggestions

http://gerrit.cloudera.org:8080/#/c/16819/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16819/1//COMMIT_MSG@9
PS1, Line 9: elaborated the existing content
Can you make these into complete sentences please? Take a look at other Impala commit messages to see the standard we are aiming for.


http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml
File docs/topics/impala_retry_failed_queries.xml:

http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@39
PS1, Line 39:     <p>If a SELECT query fails due to a cluster membership change, the Coordinator will cancel and
I think we should try to include "Cluster membership changes typically occur when an impalad crashes, or if the node is blacklisted by the Impala Coordinator" from the old text.


http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@40
PS1, Line 40:       unregister the running query and then launch a retry of the query. For e.g., if one of the
Instead of "For e.g." I think "For example" is clearer


http://gerrit.cloudera.org:8080/#/c/16819/1/docs/topics/impala_retry_failed_queries.xml@43
PS1, Line 43:       executor nodes. This feature will support retrying the entire query and NOT the individual
This feature supports



-- 
To view, visit http://gerrit.cloudera.org:8080/16819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17
Gerrit-Change-Number: 16819
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Mar 2021 21:35:57 +0000
Gerrit-HasComments: Yes