[GitHub] [incubator-doris] morningman commented on a change in pull request #2618: Add BE plugin framework (#2348)

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #2618: Add BE plugin framework (#2348)
URL: https://github.com/apache/incubator-doris/pull/2618#discussion_r393044587
 
 

 ##########
 File path: be/src/plugin/plugin_loader.cpp
 ##########
 @@ -0,0 +1,179 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#include <boost/algorithm/string/predicate.hpp>
+#include <cstring>
+
+#include "plugin/plugin_loader.h"
+#include "plugin/plugin_zip.h"
+
+#include "gutil/strings/substitute.h"
+#include "gutil/strings/util.h"
+#include "util/dynamic_util.h"
+#include "util/file_utils.h"
+#include "http/http_client.h"
+#include "util/time.h"
+#include "util/md5.h"
+#include "env/env.h"
+
+namespace doris {
+
+using namespace strings;
+
+static const std::string PLUGIN_VERSION_SYMBOL = "_plugin_interface_version";
+static const std::string PLUGIN_SIZE_SYMBOL = "_sizeof_plugin";
+static const std::string PLUGIN_STRUCT_SYMBOL = "_plugin";
+
+
+Status PluginLoader::open_valid() {
+    return Status::OK();
+}
+
+Status PluginLoader::close_valid() {
+    if (_plugin.get() != nullptr && _plugin->flags & PLUGIN_NOT_DYNAMIC_UNINSTALL) {
+        return Status::InternalError(Substitute("plugin $0 not allow dynamic uninstall", _name));
+    }
+
+    return Status::OK();
+}
+
+Status DynamicPluginLoader::install() {
+    // check already install
+    std::string so_path = _install_path + "/" + _name + "/" + _so_name;
+    if (!FileUtils::check_exist(so_path)) {
+        // no, need download zip install
+        PluginZip zip(_source);
+
+        RETURN_IF_ERROR(zip.extract(_install_path, _name));
+    }
+
+    // open plugin
+    RETURN_IF_ERROR(open_plugin());
+
+    RETURN_IF_ERROR(open_valid());
+
+    // plugin init
+    // todo: what should be send?
+    _plugin->init(nullptr);
+
+    return Status::OK();
+}
+
+/**
+ * open & valid Plugin:
+ * 1. check .so file exists
+ * 2. check .so version symbol
+ * 3. check .so plugin symbol
+ */
+Status DynamicPluginLoader::open_plugin() {
+    // check .so file
+    std::string so_path = _install_path + "/" + _name + "/" + _so_name;
+    if (!FileUtils::check_exist(so_path)) {
+        return Status::InternalError("plugin install not found " + _so_name);
+    }
+
+    RETURN_IF_ERROR(dynamic_open(so_path.c_str(), &_plugin_handler));
+
+    void* symbol;
+    // check version symbol
+    RETURN_IF_ERROR(dynamic_lookup(_plugin_handler, (_name + PLUGIN_VERSION_SYMBOL).c_str(), &symbol));
+
+    if (DORIS_PLUGIN_VERSION > *(int*) symbol) {
+        return Status::InternalError("plugin compile version to old");
 
 Review comment:
   ```suggestion
           return Status::InternalError("plugin compile version too old");
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org