You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Ed Cable <ed...@mifos.org> on 2017/09/14 06:30:35 UTC
Need for help in reviewing PRs
Hi all,
Once again not to sound like a broken record but echoing the same
sentiments in my previous email about the need for help in GSOC reviews.
The need for members of the PMC to review pull requests in general extends
beyond just these Google Summer of Code contributions. Nazeer, could use
help so there's not a backlog of pull requests to be reviewed.
Apart from just needing more hands on deck to assist, it would be ideal
that we could have a second set of eyes review pull requests that Nazeer
has himself made before they can be merged. Right now with only one
maintainer, when Nazeer is writing new features, himself, he has nobody to
do an external review.
Thanks,
Ed
--
*Ed Cable*
President/CEO, Mifos Initiative
edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
Re: Need for help in reviewing PRs
Posted by Ed Cable <ed...@mifos.org>.
Thank you Avik. I hope you can join our upcoming call discussing review
status of PRs related to the most recent round of Google Summer of Code.
Ed
On Tue, Oct 10, 2017 at 11:33 AM, Avik Ganguly <av...@gmail.com>
wrote:
> Hi Nazeer,
>
> I have done one round of review for the open PRs. Please find my comments
> for the open PRs.
>
> Backlog Tracking
> <https://docs.google.com/spreadsheets/d/1OoyPoWKrLDieDLK3Su1_c6oWN77zufA9E4hTexIU0a8/edit?usp=drive_web>
>
>
> Regards,
> Avik.
>
> On Tue, Oct 3, 2017 at 11:00 AM, Shaik Nazeer <nazeer.shaik@
> confluxtechnologies.com> wrote:
>
>> Hi Avik,
>>
>>
>>
>> Most of them are reviewed and provided with review comments. Please have
>> a look again following the older PR(s) first as sometimes contributors will
>> update same PR without creating the new ones.
>>
>>
>>
>> Regards,
>>
>> Nazeer
>>
>>
>>
>> *From:* Avik Ganguly [mailto:avikganguly010@gmail.com]
>> *Sent:* 02 October 2017 00:05
>> *To:* Dev; Nazeer Shaik
>> *Cc:* Mifos software development; private@fineract.apache.org
>> *Subject:* Re: Need for help in reviewing PRs
>>
>>
>>
>> Hi Nazeer,
>>
>>
>>
>> Are there any particular PRs I can help in reviewing or should I do a
>> scan-through / follow up on the older PRs first?
>>
>>
>>
>> Regards,
>>
>> Avik.
>>
>>
>>
>> On Thu, Sep 14, 2017 at 12:00 PM, Ed Cable <ed...@mifos.org> wrote:
>>
>> Hi all,
>>
>> Once again not to sound like a broken record but echoing the same
>> sentiments in my previous email about the need for help in GSOC reviews.
>> The need for members of the PMC to review pull requests in general extends
>> beyond just these Google Summer of Code contributions. Nazeer, could use
>> help so there's not a backlog of pull requests to be reviewed.
>>
>> Apart from just needing more hands on deck to assist, it would be ideal
>> that we could have a second set of eyes review pull requests that Nazeer
>> has himself made before they can be merged. Right now with only one
>> maintainer, when Nazeer is writing new features, himself, he has nobody to
>> do an external review.
>>
>> Thanks,
>>
>> Ed
>>
>>
>>
>> --
>> *Ed Cable*
>> President/CEO, Mifos Initiative
>> edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>> <(484)%20477-8649>
>>
>> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
>> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>>
>>
>>
>
>
--
*Ed Cable*
President/CEO, Mifos Initiative
edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
Re: Need for help in reviewing PRs
Posted by Avik Ganguly <av...@gmail.com>.
Hi Nazeer,
I have done one round of review for the open PRs. Please find my comments
for the open PRs.
Backlog Tracking
<https://docs.google.com/spreadsheets/d/1OoyPoWKrLDieDLK3Su1_c6oWN77zufA9E4hTexIU0a8/edit?usp=drive_web>
Regards,
Avik.
On Tue, Oct 3, 2017 at 11:00 AM, Shaik Nazeer <
nazeer.shaik@confluxtechnologies.com> wrote:
> Hi Avik,
>
>
>
> Most of them are reviewed and provided with review comments. Please have a
> look again following the older PR(s) first as sometimes contributors will
> update same PR without creating the new ones.
>
>
>
> Regards,
>
> Nazeer
>
>
>
> *From:* Avik Ganguly [mailto:avikganguly010@gmail.com]
> *Sent:* 02 October 2017 00:05
> *To:* Dev; Nazeer Shaik
> *Cc:* Mifos software development; private@fineract.apache.org
> *Subject:* Re: Need for help in reviewing PRs
>
>
>
> Hi Nazeer,
>
>
>
> Are there any particular PRs I can help in reviewing or should I do a
> scan-through / follow up on the older PRs first?
>
>
>
> Regards,
>
> Avik.
>
>
>
> On Thu, Sep 14, 2017 at 12:00 PM, Ed Cable <ed...@mifos.org> wrote:
>
> Hi all,
>
> Once again not to sound like a broken record but echoing the same
> sentiments in my previous email about the need for help in GSOC reviews.
> The need for members of the PMC to review pull requests in general extends
> beyond just these Google Summer of Code contributions. Nazeer, could use
> help so there's not a backlog of pull requests to be reviewed.
>
> Apart from just needing more hands on deck to assist, it would be ideal
> that we could have a second set of eyes review pull requests that Nazeer
> has himself made before they can be merged. Right now with only one
> maintainer, when Nazeer is writing new features, himself, he has nobody to
> do an external review.
>
> Thanks,
>
> Ed
>
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>
>
>
RE: Need for help in reviewing PRs
Posted by Shaik Nazeer <na...@confluxtechnologies.com>.
Hi Avik,
Most of them are reviewed and provided with review comments. Please have a look again following the older PR(s) first as sometimes contributors will update same PR without creating the new ones.
Regards,
Nazeer
From: Avik Ganguly [mailto:avikganguly010@gmail.com]
Sent: 02 October 2017 00:05
To: Dev; Nazeer Shaik
Cc: Mifos software development; private@fineract.apache.org
Subject: Re: Need for help in reviewing PRs
Hi Nazeer,
Are there any particular PRs I can help in reviewing or should I do a scan-through / follow up on the older PRs first?
Regards,
Avik.
On Thu, Sep 14, 2017 at 12:00 PM, Ed Cable <ed...@mifos.org> wrote:
Hi all,
Once again not to sound like a broken record but echoing the same
sentiments in my previous email about the need for help in GSOC reviews.
The need for members of the PMC to review pull requests in general extends
beyond just these Google Summer of Code contributions. Nazeer, could use
help so there's not a backlog of pull requests to be reviewed.
Apart from just needing more hands on deck to assist, it would be ideal
that we could have a second set of eyes review pull requests that Nazeer
has himself made before they can be merged. Right now with only one
maintainer, when Nazeer is writing new features, himself, he has nobody to
do an external review.
Thanks,
Ed
--
*Ed Cable*
President/CEO, Mifos Initiative
edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
*Collectively Creating a World of 3 Billion Maries | *http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
Re: Need for help in reviewing PRs
Posted by Avik Ganguly <av...@gmail.com>.
Hi Nazeer,
Are there any particular PRs I can help in reviewing or should I do a
scan-through / follow up on the older PRs first?
Regards,
Avik.
On Thu, Sep 14, 2017 at 12:00 PM, Ed Cable <ed...@mifos.org> wrote:
> Hi all,
>
> Once again not to sound like a broken record but echoing the same
> sentiments in my previous email about the need for help in GSOC reviews.
> The need for members of the PMC to review pull requests in general extends
> beyond just these Google Summer of Code contributions. Nazeer, could use
> help so there's not a backlog of pull requests to be reviewed.
>
> Apart from just needing more hands on deck to assist, it would be ideal
> that we could have a second set of eyes review pull requests that Nazeer
> has himself made before they can be merged. Right now with only one
> maintainer, when Nazeer is writing new features, himself, he has nobody to
> do an external review.
>
> Thanks,
>
> Ed
>
>
>
> --
> *Ed Cable*
> President/CEO, Mifos Initiative
> edcable@mifos.org | Skype: edcable | Mobile: +1.484.477.8649
>
> *Collectively Creating a World of 3 Billion Maries | *http://mifos.org
> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>